Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to styled-components@^4.0.0 blocked on jest-syled-components #49

Closed
sarathms opened this issue Mar 11, 2019 · 1 comment · Fixed by #76
Closed

Upgrade to styled-components@^4.0.0 blocked on jest-syled-components #49

sarathms opened this issue Mar 11, 2019 · 1 comment · Fixed by #76
Assignees
@sarathms
Labels
priority/medium
Projects
OONI-Verse
Milestone
Sprint 2 - Cuttle...

Comments

@sarathms
Copy link
Contributor

Styled components was previously upgraded to v4 successfully and then downgraded due to lack of ability to test the components reliably using jest-styled-components which is yet to support styled-components v4.

There is an an open ticket which tracks compatibility problems with v4.
@sarathms
Copy link
Contributor Author

There is an unsupported @next version for the jest-styled-components on npm. It needs to be checked if our tests work with it.

@sarathms sarathms mentioned this issue Mar 11, 2019
Merged
@hellais hellais added this to Icebox in OONI-Verse Oct 8, 2019
@hellais hellais mentioned this issue Dec 10, 2019
Closed
@sarathms sarathms self-assigned this Dec 11, 2019
@sarathms sarathms mentioned this issue Dec 18, 2019
Merged
@hellais hellais added this to the Sprint 2 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarathms sarathms

Labels
priority/medium
Projects
No open projects
OONI-Verse
  
Icebox
Milestone
Sprint 2 - Cuttlefish
Development

Successfully merging a pull request may close this issue.

Upgrade styled-components to v4 ooni/design-system
2 participants
@hellais @sarathms