-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the TC responsible for adding new members #923
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the membership approver pool not being expanded rather than being changed from GC to TC?
I would prefer this approver pool to be GC+TC rather than TC only since there have been bandwidth issues from the TC with the current backlog of responsibilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my understanding this isn't about the approvals, but about actually adding new members to the org, which requires permissions that the GC does not need (legislative vs. executive branch analogy).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the process is already defined by the GC and there is not too much to "approve", we just need to follow/enforce the rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this right. I suggest setting up a GitHub Admin team (similar to how k8s does this). This GH admin team would take ownership and execution of adding new members to the project. Imo delegating this responsibility to the TC may not help evaluation velocity. @SergeyKanzhelev who is on the TC (and helped enormously in ensuring membership requests were processed quickly while on the GC) may still end up doing the work and may still result in a SPOF situation within the TC.
I also think this is a great opportunity for other active contributors and members on the project to get more involved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alolita can you clarify on the next steps you propose? I think creating the new "Admin" team will take discussions, changing the charter of the TC, etc., so probably we can start that process (GC has to decide) but I would not block this especially as you said @SergeyKanzhelev being the person who did the most work.
GC right now, by the charter, does not have admin rights in the org, so not sure adding GC is feasible right now. Maybe this can also be discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is correcting factual issue. As per creating GitHub Admin team, if there are enthusiasts who are interested in this, we can initiate the process. Definitely there are many aspects of GitHub management that can be documented and improved. @alolita do you want to create a github issue to track the idea and seek for volunteers?