Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update collector core dependencies #27437

Merged
merged 2 commits into from Oct 5, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Oct 5, 2023

Had to update a Prometheus exporter test TestCollectMetrics to adapt to the metric description String() output change made the recent Prom library version prometheus/client_golang#1296.

Fixes #27398

Adopt to a change in prom metric description String() output
@djaglowski djaglowski merged commit 77036b1 into open-telemetry:main Oct 5, 2023
79 of 83 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 5, 2023
@dmitryax dmitryax deleted the upd-col-core branch October 5, 2023 15:07
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2023
Had to update a Prometheus exporter test `TestCollectMetrics` to adapt
to the metric description String() output change made the recent Prom
library version prometheus/client_golang#1296.

Fixes
open-telemetry#27398
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
Had to update a Prometheus exporter test `TestCollectMetrics` to adapt
to the metric description String() output change made the recent Prom
library version prometheus/client_golang#1296.

Fixes
open-telemetry#27398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/prometheus] Bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0 broke tests
4 participants