Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Refactor view implementation #3397

Closed
wants to merge 29 commits into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 25, 2022

See #3399

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Oct 25, 2022
@MrAlias MrAlias changed the title [WIP] Refactor view implementation [Proposal] Refactor view implementation Oct 26, 2022
@MrAlias MrAlias added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3397 (a6b8e10) into main (c21b6b6) will increase coverage by 0.2%.
The diff coverage is 95.2%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3397     +/-   ##
=======================================
+ Coverage   77.8%   78.0%   +0.2%     
=======================================
  Files        164     165      +1     
  Lines      11497   11603    +106     
=======================================
+ Hits        8945    9055    +110     
+ Misses      2349    2346      -3     
+ Partials     203     202      -1     
Impacted Files Coverage Δ
exporters/otlp/otlpmetric/exporter.go 67.2% <0.0%> (ø)
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 84.9% <0.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 77.5% <0.0%> (ø)
sdk/metric/view/view.go 97.2% <ø> (ø)
sdk/metric/periodic_reader.go 89.4% <50.0%> (ø)
...xporters/otlp/otlpmetric/internal/oconf/options.go 79.8% <100.0%> (ø)
exporters/stdout/stdoutmetric/config.go 72.9% <100.0%> (ø)
exporters/stdout/stdoutmetric/exporter.go 100.0% <100.0%> (ø)
sdk/metric/config.go 94.3% <100.0%> (ø)
sdk/metric/instrument.go 95.3% <100.0%> (+12.0%) ⬆️
... and 7 more

@MrAlias MrAlias closed this Nov 22, 2022
@MrAlias MrAlias deleted the view-deprecate branch November 22, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package proposal
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant