Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Refactor view implementation #3397

Closed
wants to merge 29 commits into from
Closed

[Proposal] Refactor view implementation #3397

wants to merge 29 commits into from

Commits on Oct 23, 2022

  1. Add view implementation to sdk/metric pkg

    @MrAlias
    MrAlias committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    e8b62c0 View commit details
    Browse the repository at this point in the history

  2. Deprecated view pkg in favor of sdk/metric views

    @MrAlias
    MrAlias committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    ba9993a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Drop MatchFuncs 

    Have NewView take filter and apply masks to construct a view directly,
instead of taking variable number of matching functions.
    @MrAlias
    MrAlias committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    d3ee653 View commit details
    Browse the repository at this point in the history

  2. Use new view implementation

    @MrAlias
    MrAlias committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    02742b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Rename InstrumentStream to DataStream

    @MrAlias
    MrAlias committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    bdee2ed View commit details
    Browse the repository at this point in the history

  2. Fix InstrumentProperties.mask for Unit

    @MrAlias
    MrAlias committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    9829b1e View commit details
    Browse the repository at this point in the history

  3. Add view tests

    @MrAlias
    MrAlias committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    f291038 View commit details
    Browse the repository at this point in the history

  4. Add NewView example tests

    @MrAlias
    MrAlias committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    e7a25b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Rename InstrumentProperties to Instrument

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    88b5315 View commit details
    Browse the repository at this point in the history

  2. Add temporality to data stream

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    1dcd612 View commit details
    Browse the repository at this point in the history

  3. Rename DataStream to Stream

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    488f6c3 View commit details
    Browse the repository at this point in the history

  4. Add deprecation notices to exported types of view

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    0ced1d0 View commit details
    Browse the repository at this point in the history

  5. Fix spelling errors

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    fd3cd30 View commit details
    Browse the repository at this point in the history

  6. Add docs for private methods of Instrument

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    8e22a21 View commit details
    Browse the repository at this point in the history

  7. Fix view example

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    267ae59 View commit details
    Browse the repository at this point in the history

  8. Lint sdk/metric

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5714ca6 View commit details
    Browse the repository at this point in the history

  9. Fix prom exp use of views

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    8a243f2 View commit details
    Browse the repository at this point in the history

  10. Ignore lint false-positive of used nonComparable

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    f061ec4 View commit details
    Browse the repository at this point in the history

  11. Add View example

    @MrAlias
    MrAlias committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    45b1008 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge branch 'main' into view-deprecate

    @MrAlias
    MrAlias committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    2a8d1f6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into view-deprecate

    @MrAlias
    MrAlias committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    49ba1cd View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Merge branch 'main' into view-deprecate

    @MrAlias
    MrAlias committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3b9543c View commit details
    Browse the repository at this point in the history

  2. Update sdk/metric docs

    @MrAlias
    MrAlias committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    da15cac View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into view-deprecate

    @MrAlias
    MrAlias committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    657af01 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Merge branch 'main' into view-deprecate

    @MrAlias
    MrAlias committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    e2a92f3 View commit details
    Browse the repository at this point in the history

  2. Fix benchmark_test

    @MrAlias
    MrAlias committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    4a45cf0 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Merge branch 'main' into view-deprecate

    @MrAlias
    MrAlias committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    384e7f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge branch 'main' into view-deprecate

    @MrAlias
    MrAlias committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f5a9033 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Merge branch 'main' into view-deprecate

    @MrAlias
    MrAlias committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    a6b8e10 View commit details
    Browse the repository at this point in the history