sdk/resource: Add Resource.WithoutSchemaURL #4484
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2341
Fixes #3769
Fixes #4476
This should mitigate a common problem. Most users seem to want to have some "easy fix".
Pros:
Current alternative:
resource.NewSchemaless(r.Attributes()…)
. However, this is clunky and it is not efficient as it copies a slice (which is not needed asattribute.Set
is immutable).Side notes:
I was also thinking of adding an option to
Merge
, but this would be not compliant with the specification. Also it would be hard to answer what schemaURL should be set in case of a conflict.