Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: enable typescript 4.3 noImplicitOverride option #90

Merged
merged 2 commits into from Jun 7, 2021
Merged

chore: enable typescript 4.3 noImplicitOverride option #90

merged 2 commits into from Jun 7, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jun 5, 2021

Enable typescript 4.3 feature noImplicitOverride to improve code quality.
Besides that some other dev-dependencies are updated.

Enable typescript 4.3 feature noImplicitOverride to improve code quality.
Besides that some other dev-dependencies are updated.
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #90 (79c3e0b) into main (726fd82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          42       42           
  Lines         561      561           
  Branches       87       87           
=======================================
  Hits          532      532           
  Misses         29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec36492...79c3e0b. Read the comment docs.

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't all noop implementation use override keyword too ?

@Flarna
Copy link
Member Author

Flarna commented Jun 6, 2021

shouldn't all noop implementation use override keyword too ?

The noop classes do not override anything from a base class - they implement an interface. override in typescript seems to be slightly different then in java or C++.

@dyladan dyladan merged commit 6397bc8 into open-telemetry:main Jun 7, 2021
@Flarna Flarna deleted the ts-override branch June 8, 2021 07:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants