Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: enable typescript 4.3 noImplicitOverride option #90

Merged
merged 2 commits into from Jun 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions package.json
Expand Up @@ -56,16 +56,16 @@
},
"devDependencies": {
"@types/mocha": "8.2.2",
"@types/node": "14.14.42",
"@types/sinon": "10.0.0",
"@types/node": "14.17.1",
"@types/sinon": "10.0.2",
"@types/webpack-env": "1.16.0",
"@typescript-eslint/eslint-plugin": "4.22.0",
"@typescript-eslint/parser": "4.22.0",
"codecov": "3.8.1",
"eslint": "7.25.0",
"@typescript-eslint/eslint-plugin": "4.26.0",
"@typescript-eslint/parser": "4.26.0",
"codecov": "3.8.2",
"eslint": "7.28.0",
"eslint-plugin-header": "3.1.1",
"eslint-plugin-import": "2.22.1",
"gh-pages": "3.1.0",
"eslint-plugin-import": "2.23.4",
"gh-pages": "3.2.0",
"gts": "3.1.0",
"istanbul-instrumenter-loader": "3.0.1",
"karma": "5.2.3",
Expand All @@ -78,11 +78,11 @@
"linkinator": "2.13.6",
"mocha": "7.2.0",
"nyc": "15.1.0",
"sinon": "10.0.0",
"sinon": "11.1.1",
"ts-loader": "8.2.0",
"ts-mocha": "8.0.0",
"typedoc": "0.20.36",
"typescript": "4.2.4",
"typedoc": "0.21.0-beta.1",
"typescript": "4.3.2",
"webpack": "4.46.0"
}
}
4 changes: 2 additions & 2 deletions test/api/api.test.ts
Expand Up @@ -94,13 +94,13 @@ describe('API', () => {
});

class TestTracer extends NoopTracer {
startSpan(name: string, options?: SpanOptions): Span {
override startSpan(name: string, options?: SpanOptions): Span {
return dummySpan;
}
}

class TestTracerProvider extends NoopTracerProvider {
getTracer(_name: string, version?: string) {
override getTracer(_name: string, version?: string) {
return new TestTracer();
}
}
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Expand Up @@ -10,6 +10,7 @@
"noFallthroughCasesInSwitch": true,
"noImplicitReturns": true,
"noUnusedLocals": true,
"noImplicitOverride": true,
"outDir": "build",
"pretty": true,
"rootDir": ".",
Expand Down