Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instr-express): use exported strings for attributes #2031

Merged

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

In express instrumentation package:

  • Update @opentelemetry/semantic-conventions to ^1.22
  • Replace SemanticAttributes.HTTP_ROUTE with exported string SEMATTRS_HTTP_ROUTE
  • Update README with new semantic convention package version and key

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #2031 (f21b8b0) into main (dfb2dff) will increase coverage by 0.00%.
Report is 14 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2031   +/-   ##
=======================================
  Coverage   90.97%   90.98%           
=======================================
  Files         146      145    -1     
  Lines        7492     7454   -38     
  Branches     1502     1488   -14     
=======================================
- Hits         6816     6782   -34     
+ Misses        676      672    -4     
Files Coverage Δ
...try-instrumentation-express/src/instrumentation.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 🙂
Were the tests left out intentionally? 🤔

@JamieDanielson
Copy link
Member Author

Were the tests left out intentionally? 🤔

🤦‍♀️ Oops! No they were not!

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 🙂

@pichlermarc pichlermarc merged commit 6cd67c0 into open-telemetry:main Mar 22, 2024
17 checks passed
@JamieDanielson JamieDanielson deleted the jamie.express-exported-strings branch March 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants