Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of semantic conventions to new exported strings #2025

Open
41 of 59 tasks
Tracked by #4572
JamieDanielson opened this issue Mar 19, 2024 · 17 comments
Open
41 of 59 tasks
Tracked by #4572

Update usage of semantic conventions to new exported strings #2025

JamieDanielson opened this issue Mar 19, 2024 · 17 comments
Labels
good first issue needs:code-contribution This feature/bug is ready to implement type:feature-tracking A feature with sub-issues that need to be addressed up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@JamieDanielson
Copy link
Member

JamieDanielson commented Mar 19, 2024 •
edited

This is somewhat related to #1778 , which is for documenting current semantic convention versions for each instrumentation package.

This issue is intended to track the necessary change of updating each package to use the new exports for semantic conventions that were added in open-telemetry/opentelemetry-js#4298 and now available in v1.22.0.

Each package will need to

  • update the dependency for @opentelemetry/semantic-conventions to "^1.22.0"
  • update the imported semantic convention to match the new version, i.e. HTTP_ROUTE becomes SEMATTRS_HTTP_ROUTE

Please limit PRs to a single package in order to make them quickly and easily reviewable.
If you are working on one of the below packages, please comment so others know the issue is being worked on.

EDIT: updated to add other packages that will need replacements for the deprecated attributes:
@pichlermarc pichlermarc added type:feature-tracking A feature with sub-issues that need to be addressed good first issue needs:code-contribution This feature/bug is ready to implement up-for-grabs Good for taking. Extra help will be provided by maintainers labels Mar 20, 2024
@JamieDanielson
Copy link
Member Author

I am updating the express package

This was referenced Mar 21, 2024
Merged
Open
@JamieDanielson JamieDanielson changed the title Update instrumentation semantic conventions to new exported strings Update usage of semantic conventions to new exported strings Mar 21, 2024
@JamieDanielson JamieDanielson mentioned this issue Mar 21, 2024
Open
7 tasks
@MrFabio MrFabio mentioned this issue Mar 21, 2024
Merged
@MrFabio
Copy link
Contributor

MrFabio commented Mar 21, 2024

I am updating the koa package #2033

@JamieDanielson JamieDanielson mentioned this issue Mar 26, 2024
Merged
@JamieDanielson
Copy link
Member Author

Updating instrumentation-document-load package #2039

@maryliag
Copy link
Contributor

I am updating all the resource detector packages

This was referenced Mar 27, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@maryliag
Copy link
Contributor

also updated the instrumentation-pg plugin

@JamieDanielson
Copy link
Member Author

Also! A great follow-up PR (or maybe even the same PR, depending on how big the PR is) is to add the attributes to the README as listed in this issue #1778 . As an example, check out open-telemetry/opentelemetry-js#4587 😄

@maryliag
Copy link
Contributor

I can do that for the ones I updated. I will do on a follow PRs, because I currently have a few PRs up updating those same README files and want to avoid the conflict. So once those are merged I will update with the missing info for this.

MrFabio added a commit to MrFabio/opentelemetry-js-contrib that referenced this issue Mar 29, 2024
@MrFabio
feat(koa): Updated package-lock.json open-telemetry#2025
be5346f
pichlermarc added a commit that referenced this issue Apr 2, 2024
@MrFabio @pichlermarc
feat(koa): Use exported strings for attributes (#2033)
70090c1 
* feat(koa): Use exported strings for attributes

* feat(koa): Updated package-lock.json #2025

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Zirak added a commit to Zirak/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
@Zirak
refactor(instrumentation-redis): Use exported semconv strings
63d46cc 
Part of open-telemetry#2025.
Zirak added a commit to Zirak/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
@Zirak
refactor(instrumentation-redis): Use exported semconv strings
d34856b 
Part of open-telemetry#2025.
@Zirak Zirak mentioned this issue Apr 3, 2024
Merged
maryliag added a commit to maryliag/opentelemetry-js-contrib that referenced this issue Apr 3, 2024
@maryliag
add Semantic Conventions to alibaba README
3b50718 
Add Semantic Conventions to Alibaba README

PArt Of open-telemetry#2025

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
@david-luna david-luna mentioned this issue Apr 23, 2024
Merged
@JamieDanielson JamieDanielson mentioned this issue Apr 23, 2024
Merged
@JamieDanielson
Copy link
Member Author

JamieDanielson commented Apr 23, 2024 •
edited

picking up aws-sdk

@JamieDanielson JamieDanielson mentioned this issue Apr 23, 2024
Merged
This was referenced Apr 24, 2024
Merged
Merged
trentm pushed a commit that referenced this issue Apr 24, 2024
@maryliag
chore(examples/web): use exported strings for attributes (#2129)
5f1910b 
Use exported strings for Semantic Attributes

Refs: #2025
trentm pushed a commit that referenced this issue Apr 24, 2024
@maryliag
chore(examples/connect): use exported strings for attributes (#2120)
77452c1 
Use exported strings for Semantic Resource Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Refs: #2025
@david-luna david-luna mentioned this issue Apr 25, 2024
Merged
trentm pushed a commit that referenced this issue Apr 25, 2024
@maryliag
chore(examples/redis): use exported strings for attributes (#2128)
b0ac2c9 
Use exported strings for Semantic Attributes

Refs: #2025
trentm pushed a commit that referenced this issue Apr 25, 2024
@maryliag
chore(examples/react-load): use exported strings for attributes (#2127)
c96293d 
Use exported strings for Semantic Attributes

Refs: #2025
trentm pushed a commit that referenced this issue Apr 25, 2024
@maryliag
chore(examples/mysql): use exported strings for attributes (#2126)
09c8e42 
Use exported strings for Semantic Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Refs: #2025
trentm pushed a commit that referenced this issue Apr 25, 2024
@maryliag
chore(examples/mongodb): use exported strings for attributes (#2125)
4a4a087 
Use exported strings for Semantic Attributes

Refs: #2025
trentm pushed a commit that referenced this issue Apr 25, 2024
@maryliag
chore(examples/memcached): use exported strings for attributes (#2124)
e04362a 
Use exported strings for Semantic Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Refs: #2025
trentm pushed a commit that referenced this issue Apr 25, 2024
@maryliag
chore(examples/koa): use exported strings for attributes (#2123)
7f5f20c 
Use exported strings for Semantic Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Refs: #2025
trentm pushed a commit that referenced this issue Apr 25, 2024
@maryliag
chore(examples/express): use exported strings for attributes (#2121)
7822461 
Use exported strings for Semantic Resource Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Refs: #2025
This was referenced Apr 26, 2024
Merged
Open
trentm added a commit that referenced this issue May 1, 2024
@david-luna @trentm
refactor(instr-cassandra-driver): use exported strings for attributes (…
e74cee4 
…#2139)

Also, correct component-label mapping for instrumentation-cassandra-driver package

Co-authored-by: Trent Mick <trentm@gmail.com>
Refs: #2025
@JamieDanielson JamieDanielson mentioned this issue May 7, 2024
Open
@JamieDanielson
Copy link
Member Author

For a smaller list, these are remaining packages that still need to get updated in this repo:

  • @opentelemetry/instrumentation-bunyan (dev dep)
  • @opentelemetry/instrumentation-hapi
  • @opentelemetry/instrumentation-ioredis
  • @opentelemetry/instrumentation-memcached
  • @opentelemetry/instrumentation-nestjs-core
  • @opentelemetry/instrumentation-net
  • @opentelemetry/instrumentation-long-task
  • @opentelemetry/instrumentation-user-interaction
  • @opentelemetry/browser-extension-autoinjection (this is archived, do we still need to update it?)

@JamieDanielson
Copy link
Member Author

These packages do not seem to have semantic conventions; I am opening a PR for them to document as such and remove any unused semantic-convention packages

  • @opentelemetry/instrumentation-lru-memoizer
  • @opentelemetry/instrumentation-dns
  • @opentelemetry/instrumentation-generic-pool
  • @opentelemetry/instrumentation-pino
  • @opentelemetry/instrumentation-winston
  • @opentelemetry/plugin-react-load
  • @opentelemetry/sampler-aws-xray

@JamieDanielson JamieDanielson mentioned this issue May 7, 2024
Open
This was referenced May 10, 2024
Open
Open
Open
Open
Open
Open
@maryliag
Copy link
Contributor

Updated the ones from your latest list:

I didn't update long-task and user-interaction because I didn't actually see any usage of the semantic convention package on then, maybe am I missing something?
Also, don't think we should update an archived package, so I didn't do the extension-autoinjection

Seems to be some errors with the tests on the hapi one, I will try to look into it when I get some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue needs:code-contribution This feature/bug is ready to implement type:feature-tracking A feature with sub-issues that need to be addressed up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@david-luna @maryliag @MrFabio @pichlermarc @JamieDanielson