New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(koa): Use exported strings for attributes #2033
feat(koa): Use exported strings for attributes #2033
Conversation
d9b99d6
to
9d5ebb6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
- Coverage 90.97% 90.63% -0.34%
==========================================
Files 146 146
Lines 7492 7488 -4
Branches 1502 1494 -8
==========================================
- Hits 6816 6787 -29
- Misses 676 701 +25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, needs a npm run lint:fix
before we can merge this.
(see failing lint step)
c1de936
to
98c67e3
Compare
98c67e3
to
fb2d67e
Compare
have you ran
|
Thanks @maryliag ! |
I just don't have permission to merge, so hopefully someone else can merge this for you 😄 |
Which problem is this PR solving?
Short description of the changes
In koa instrumentation package:
@opentelemetry/semantic-conventions
to^1.22
SemanticAttributes.HTTP_ROUTE
with exported stringSEMATTRS_HTTP_ROUTE