Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(koa): Use exported strings for attributes #2033

Merged
merged 5 commits into from Apr 2, 2024

Conversation

MrFabio
Copy link
Contributor

@MrFabio MrFabio commented Mar 21, 2024

Which problem is this PR solving?

Short description of the changes

In koa instrumentation package:

  • Update @opentelemetry/semantic-conventions to ^1.22
  • Replace SemanticAttributes.HTTP_ROUTE with exported string SEMATTRS_HTTP_ROUTE

pichlermarc
pichlermarc previously approved these changes Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #2033 (de90829) into main (dfb2dff) will decrease coverage by 0.34%.
Report is 27 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head de90829 differs from pull request most recent head 22196e9. Consider uploading reports for the commit 22196e9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2033      +/-   ##
==========================================
- Coverage   90.97%   90.63%   -0.34%     
==========================================
  Files         146      146              
  Lines        7492     7488       -4     
  Branches     1502     1494       -8     
==========================================
- Hits         6816     6787      -29     
- Misses        676      701      +25     
Files Coverage Δ
...ode/opentelemetry-instrumentation-koa/src/utils.ts 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, needs a npm run lint:fix before we can merge this.
(see failing lint step)

@pichlermarc pichlermarc self-requested a review March 22, 2024 15:09
@pichlermarc pichlermarc dismissed their stale review March 22, 2024 15:09

lint step failing

@MrFabio MrFabio force-pushed the feature/koa-attributes branch 2 times, most recently from c1de936 to 98c67e3 Compare March 22, 2024 17:28
@maryliag
Copy link
Contributor

maryliag commented Mar 28, 2024

have you ran npm install on the package? I'm not seeing the correspondent package-lock.json changes on

"@opentelemetry/instrumentation-koa": {
      "version": "file:plugins/node/opentelemetry-instrumentation-koa",
      "requires": {
        "@koa/router": "12.0.0",
        ...
        "@opentelemetry/semantic-conventions": "^1.0.0",  <--- this one should be the new version

@MrFabio
Copy link
Contributor Author

MrFabio commented Mar 29, 2024

Thanks @maryliag !

@maryliag
Copy link
Contributor

I just don't have permission to merge, so hopefully someone else can merge this for you 😄

@pichlermarc pichlermarc merged commit 70090c1 into open-telemetry:main Apr 2, 2024
10 of 12 checks passed
@dyladan dyladan mentioned this pull request Mar 29, 2024
@MrFabio MrFabio deleted the feature/koa-attributes branch April 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants