Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resource-detector-alibaba): use exported strings for attributes #2046

Merged
merged 2 commits into from Apr 2, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package opentelemetry-resource-detector-alibaba-cloud:

  • Update @opentelemetry/semantic-conventions from ^1.0.0 to ^1.22.0
  • Use exported strings for Semantic Resource Attributes, Cloud Platform Values and Cloud Provider Values.

@JamieDanielson
Copy link
Member

Just a note, I recently updated the CONTRIBUTING doc because we no longer need to update the changelog on our own in PRs - it gets updated in the releasing step!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #2046 (ab344a8) into main (dfb2dff) will decrease coverage by 0.34%.
Report is 28 commits behind head on main.
The diff coverage is n/a.

❗ Current head ab344a8 differs from pull request most recent head 0e8f000. Consider uploading reports for the commit 0e8f000 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
- Coverage   90.97%   90.63%   -0.34%     
==========================================
  Files         146      146              
  Lines        7492     7488       -4     
  Branches     1502     1494       -8     
==========================================
- Hits         6816     6787      -29     
- Misses        676      701      +25     
Files Coverage Δ
...aba-cloud/src/detectors/AlibabaCloudEcsDetector.ts 97.67% <ø> (ø)

... and 8 files with indirect coverage changes

@maryliag
Copy link
Contributor Author

Updated to remove the changes on changelog

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 🙂

Use exported strings for Semantic Resource Attributes, Cloud Platform Values and Cloud Provider Values.

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
@pichlermarc pichlermarc merged commit 35e6607 into open-telemetry:main Apr 2, 2024
12 checks passed
@maryliag maryliag deleted the update-alibaba branch April 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants