New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(resource-detector-azure): use exported strings for attributes #2048
Conversation
Just a note, I recently updated the CONTRIBUTING doc because we no longer need to update the changelog on our own in PRs - it gets updated in the releasing step! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
- Coverage 90.97% 90.63% -0.34%
==========================================
Files 146 146
Lines 7492 7488 -4
Branches 1502 1494 -8
==========================================
- Hits 6816 6787 -29
- Misses 676 701 +25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the lint step failed. You can ignore the warnings but locally try running npm run lint:fix
and that should sort out the errors!
Updated to remove the changes on changelog. |
067c56c
to
0f078ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
4200bf1
to
de28045
Compare
@JamieDanielson thank you for the review! I don't have permission to merge it, so hopefully someone else can merge it for me 😄 |
Use exported strings for Semantic Resource Attributes, Cloud Platform Values and Cloud Provider Values. Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
🤨 Really? This was 2w ago, so you may not have details. If you do, I'm a little curious if there is an issue with a very new Node.js version. |
FWIW, I was able to lint with Node v21.7.2:
|
I don't have the error messages anymore, but if it happens again in the future I will open an issue with details so it can be properly investigated 😄 |
Which problem is this PR solving?
Short description of the changes
On package
opentelemetry-resource-detector-azure
:@opentelemetry/semantic-conventions
from^1.0.0
to^1.22.0