Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resource-detector-azure): use exported strings for attributes #2048

Merged
merged 2 commits into from Apr 9, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package opentelemetry-resource-detector-azure:

  • Update @opentelemetry/semantic-conventions from ^1.0.0 to ^1.22.0
  • Use exported strings for Semantic Resource Attributes, Cloud Platform Values and Cloud Provider Values.

@JamieDanielson
Copy link
Member

Just a note, I recently updated the CONTRIBUTING doc because we no longer need to update the changelog on our own in PRs - it gets updated in the releasing step!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #2048 (f4fa499) into main (dfb2dff) will decrease coverage by 0.34%.
Report is 36 commits behind head on main.
The diff coverage is n/a.

❗ Current head f4fa499 differs from pull request most recent head cd268b2. Consider uploading reports for the commit cd268b2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2048      +/-   ##
==========================================
- Coverage   90.97%   90.63%   -0.34%     
==========================================
  Files         146      146              
  Lines        7492     7488       -4     
  Branches     1502     1494       -8     
==========================================
- Hits         6816     6787      -29     
- Misses        676      701      +25     
Files Coverage Δ
...tor-azure/src/detectors/AzureAppServiceDetector.ts 96.66% <ø> (ø)
...ctor-azure/src/detectors/AzureFunctionsDetector.ts 100.00% <ø> (ø)
...ce-detector-azure/src/detectors/AzureVmDetector.ts 80.64% <ø> (ø)

... and 8 files with indirect coverage changes

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the lint step failed. You can ignore the warnings but locally try running npm run lint:fix and that should sort out the errors!

@maryliag
Copy link
Contributor Author

Updated to remove the changes on changelog.
I was having some issues making my lint run locally, after a few more tries and changes of versions (looks like my Node was too new), I was able to make it work now and fixed the changes 😄

@maryliag maryliag force-pushed the update-azure branch 2 times, most recently from 067c56c to 0f078ac Compare April 2, 2024 13:50
Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@maryliag maryliag force-pushed the update-azure branch 2 times, most recently from 4200bf1 to de28045 Compare April 3, 2024 13:01
@maryliag
Copy link
Contributor Author

maryliag commented Apr 3, 2024

@JamieDanielson thank you for the review! I don't have permission to merge it, so hopefully someone else can merge it for me 😄

Use exported strings for Semantic Resource Attributes, Cloud Platform Values and Cloud Provider Values.

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
@trentm
Copy link
Contributor

trentm commented Apr 9, 2024

I was having some issues making my lint run locally, after a few more tries and changes of versions (looks like my Node was too new)

🤨 Really? This was 2w ago, so you may not have details. If you do, I'm a little curious if there is an issue with a very new Node.js version.

@trentm trentm merged commit f090801 into open-telemetry:main Apr 9, 2024
15 checks passed
@trentm
Copy link
Contributor

trentm commented Apr 9, 2024

If you do, I'm a little curious if there is an issue with a very new Node.js version.

FWIW, I was able to lint with Node v21.7.2:

nvm install v21.7.2
npm ci --ignore-scripts
npm run lint

@maryliag maryliag deleted the update-azure branch April 9, 2024 20:27
@maryliag
Copy link
Contributor Author

maryliag commented Apr 9, 2024

I don't have the error messages anymore, but if it happens again in the future I will open an issue with details so it can be properly investigated 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants