Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resource-detector-instana): use exported strings for attributes #2051

Merged
merged 3 commits into from Apr 9, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package opentelemetry-resource-detector-instana:

  • Update @opentelemetry/semantic-conventions from ^1.0.0 to ^1.22.0
  • Use exported strings for Semantic Resource Attributes.

@JamieDanielson
Copy link
Member

Just a note, I recently updated the CONTRIBUTING doc because we no longer need to update the changelog on our own in PRs - it gets updated in the releasing step!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #2051 (e079ce8) into main (dfb2dff) will decrease coverage by 0.16%.
Report is 37 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2051      +/-   ##
==========================================
- Coverage   90.97%   90.82%   -0.16%     
==========================================
  Files         146      148       +2     
  Lines        7492     7672     +180     
  Branches     1502     1537      +35     
==========================================
+ Hits         6816     6968     +152     
- Misses        676      704      +28     
Files Coverage Δ
...ctor-instana/src/detectors/InstanaAgentDetector.ts 96.42% <100.00%> (ø)

... and 8 files with indirect coverage changes

@maryliag
Copy link
Contributor Author

Updated to remove the changes on changelog

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one README nit.

@@ -31,7 +31,7 @@ import { NodeSDK } from "@opentelemetry/sdk-node";
import { instanaAgentDetector } from "@opentelemetry/resource-detector-instana";

const globalResource = new Resource({
[SemanticResourceAttributes.SERVICE_NAME]: "TestService",
[SEMRESATTRS_SERVICE_NAME]: "TestService",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps update the import { SemanticResourceAttributes } from "@opentelemetry/semantic-conventions"; a couple lines up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Done

Use exported strings for Semantic Resource Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @maryliag ! Just a note, it's helpful for reviewers if you actually do not force-push changes, and instead keep the history. Not a big deal on smaller PRs, but as changes are made it can be difficult to see what's changed.

@trentm trentm merged commit cf25c50 into open-telemetry:main Apr 9, 2024
17 checks passed
@maryliag maryliag deleted the update-instana branch April 9, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants