New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(host-metrics): semcov alignment & macOS fix #2071
Open
Netail
wants to merge
35
commits into
open-telemetry:main
Choose a base branch
from
Netail:fix/host-metrics-bundling
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
2c6d8cf
fix: semcov alignment & reduce import bundle
Netail 60e0933
fix: types?
Netail 65aabe7
Merge branch 'main' into fix/host-metrics-bundling
Netail ae578fc
fix: ci/cd
Netail ce92ffe
Merge branch 'main' into fix/host-metrics-bundling
Netail e818ba5
Merge branch 'main' into fix/host-metrics-bundling
Netail 2484ef6
Merge branch 'main' into fix/host-metrics-bundling
Netail 1106e97
docs: specify semantic conventions
Netail 8f65520
revert some changes
Netail 08506a4
Merge branch 'main' into fix/host-metrics-bundling
Netail 63cc39d
fix: small type improvement
Netail 03e2237
docs: add small comment
Netail 9cbe462
Merge branch 'main' into fix/host-metrics-bundling
Netail a2aaa4b
Merge branch 'main' into fix/host-metrics-bundling
Netail 744ea1d
fix: feedback
Netail cc8aafe
Merge branch 'main' into fix/host-metrics-bundling
Netail d1c1fca
Merge branch 'main' into fix/host-metrics-bundling
Netail a3b898f
Merge branch 'main' into fix/host-metrics-bundling
Netail a8196e4
fix: feedback
Netail 304dc98
Merge branch 'main' into fix/host-metrics-bundling
Netail 9f81a2d
Merge branch 'main' into fix/host-metrics-bundling
Netail 769de9e
Merge branch 'main' into fix/host-metrics-bundling
Netail 4fd1f8f
Merge branch 'main' into fix/host-metrics-bundling
Netail 9c30315
Merge branch 'main' into fix/host-metrics-bundling
Netail 83c58a3
Merge branch 'main' into fix/host-metrics-bundling
Netail 2ac772e
Merge branch 'main' into fix/host-metrics-bundling
Netail 343733e
Merge branch 'main' into fix/host-metrics-bundling
Netail fd50fe5
Merge branch 'main' into fix/host-metrics-bundling
Netail 38b80b1
Merge branch 'main' into fix/host-metrics-bundling
Netail b642766
Merge branch 'main' into fix/host-metrics-bundling
Netail 5e6370a
Merge branch 'main' into fix/host-metrics-bundling
Netail deb3257
Merge branch 'main' into fix/host-metrics-bundling
Netail 5922334
fix: feedback
Netail 06ac5e7
Merge branch 'main' into fix/host-metrics-bundling
Netail a3f9a61
Merge branch 'main' into fix/host-metrics-bundling
Netail File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about
systeminformation
but deep-imports like this are usually not covered by stability guarantees. would this work for you?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pichlermarc Sadly not, it still imports the
/lib/cpu
file for some reason. Resulting in having to add the unnecessary dependencyosx-temperature-sensor
, which is not even used by networkStats()There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "having to add"? It looks like lib/cpu.js lazily does
require('osx-temperature-sensor')
only ifcpuTemperature()
is called.