Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda): update semconv package and readme #2181

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Update @opentelemetry/semantic-conventions to ^1.22 for aws-lambda instrumentation
  • Update README with new semantic convention package version and key

Note I inadvertently included some changes on #2142 when updating the aws-sdk instrumentation. This finishes that work by also updating the package and documenting in the README. I labeled as a fix as I'm not sure if there will be an issue with the current released version of aws-lambda instrumentation without the correct package (or if it will do the same as it seems to have done here, which I think is to pull from the next available package with these attributes)

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (dfb2dff) to head (dfc8514).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
- Coverage   90.97%   90.00%   -0.98%     
==========================================
  Files         146      140       -6     
  Lines        7492     6903     -589     
  Branches     1502     1453      -49     
==========================================
- Hits         6816     6213     -603     
- Misses        676      690      +14     

see 48 files with indirect coverage changes

@JamieDanielson JamieDanielson merged commit b432929 into open-telemetry:main May 14, 2024
17 checks passed
@JamieDanielson JamieDanielson deleted the jamie.update-aws-lambda-semconv branch May 14, 2024 20:15
@dyladan dyladan mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants