chore(instrumentation-ioredis): use exported strings for attributes #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to exported strings for Resource Attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
- Coverage 90.97% 90.47% -0.51%
==========================================
Files 146 149 +3
Lines 7492 7592 +100
Branches 1502 1591 +89
==========================================
+ Hits 6816 6869 +53
- Misses 676 723 +47
|
59 tasks
trentm
reviewed
May 10, 2024
| cmd.name, | ||
| cmd.args | ||
| ), | ||
| [SEMATTRS_DB_SYSTEM]: DbSystemValues.REDIS, |
There was a problem hiding this comment.
This DbSystemValues usage should be udpated as well, I think.
trentm
approved these changes
May 13, 2024
| @@ -69,7 +69,7 @@ | |||
| "dependencies": { | |||
| "@opentelemetry/instrumentation": "^0.51.0", | |||
| "@opentelemetry/redis-common": "^0.36.2", | |||
| "@opentelemetry/semantic-conventions": "^1.0.0" | |||
| "@opentelemetry/semantic-conventions": "^1.23.0" | |||
There was a problem hiding this comment.
nit: This should be ^1.22.0 right?
Suggested change
| "@opentelemetry/semantic-conventions": "^1.23.0" | |
| "@opentelemetry/semantic-conventions": "^1.22.0" |
There was a problem hiding this comment.
I just though if we are making an update, might as well update to the latest, so I did this on purpose. The message on readme says about 1.22+ to accommodate when this would happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
On package
opentelemetry-instrumentation-ioredis:@opentelemetry/semantic-conventions^1.23.0