Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation-nestjs-core): use strings exported for attributes #2193

Merged
merged 3 commits into from May 14, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package opentelemetry-instrumentation-nestjs-core:

  • Update @opentelemetry/semantic-conventions ^1.23.0
  • Use exported strings for Semantic Attributes.

Update strings exported for Resource Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (dfb2dff) to head (d62fee7).
Report is 109 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2193      +/-   ##
==========================================
- Coverage   90.97%   90.47%   -0.51%     
==========================================
  Files         146      149       +3     
  Lines        7492     7592     +100     
  Branches     1502     1591      +89     
==========================================
+ Hits         6816     6869      +53     
- Misses        676      723      +47     
Files Coverage Δ
...instrumentation-nestjs-core/src/instrumentation.ts 95.40% <100.00%> (-0.25%) ⬇️

... and 34 files with indirect coverage changes

@trentm
Copy link
Contributor

trentm commented May 13, 2024

These attributes are not in semconv:

component
nestjs.version
nestjs.type
nestjs.module
nestjs.controller nestjs.callback`

and are relevant for the outcome of #2170
That's for later, though; not part of this PR.

@@ -71,7 +71,7 @@
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.51.0",
"@opentelemetry/semantic-conventions": "^1.0.0"
"@opentelemetry/semantic-conventions": "^1.23.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
"@opentelemetry/semantic-conventions": "^1.23.0"
"@opentelemetry/semantic-conventions": "^1.22.0"

@trentm trentm enabled auto-merge (squash) May 14, 2024 18:37
@trentm trentm merged commit 7795ff6 into open-telemetry:main May 14, 2024
9 checks passed
@maryliag maryliag deleted the sem-nestjs branch May 14, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants