Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation-net): use strings exported for attributes #2194

Merged
merged 3 commits into from May 14, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package opentelemetry-instrumentation-net:

  • Update @opentelemetry/semantic-conventions ^1.23.0
  • Use exported strings for Semantic Attributes.

Update strings exported for Resource Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (dfb2dff) to head (dcde872).
Report is 109 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2194      +/-   ##
==========================================
- Coverage   90.97%   90.46%   -0.52%     
==========================================
  Files         146      149       +3     
  Lines        7492     7592     +100     
  Branches     1502     1591      +89     
==========================================
+ Hits         6816     6868      +52     
- Misses        676      724      +48     
Files Coverage Δ
...lemetry-instrumentation-net/src/instrumentation.ts 97.14% <ø> (-0.99%) ⬇️
...ode/opentelemetry-instrumentation-net/src/utils.ts 92.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the intent to add the ## Semantic Conventions section with the attributes table to the README in this PR (and in some of the other PRs in this round) or to do that separately?

@maryliag
Copy link
Contributor Author

updated the readme (on this PR and the other ones too)

@@ -59,7 +59,7 @@
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.51.0",
"@opentelemetry/semantic-conventions": "^1.0.0"
"@opentelemetry/semantic-conventions": "^1.23.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
"@opentelemetry/semantic-conventions": "^1.23.0"
"@opentelemetry/semantic-conventions": "^1.22.0"

Thought perhaps I'm wrong and 1.23 is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the other PR, I decided to get the latest version, since it also works

@trentm trentm enabled auto-merge (squash) May 14, 2024 18:38
@trentm trentm merged commit 416337e into open-telemetry:main May 14, 2024
8 checks passed
@maryliag maryliag deleted the sem-net branch May 14, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants