Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move api into peer dependency #522

Merged
merged 2 commits into from Jun 7, 2021
Merged

chore: move api into peer dependency #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
153128d
chore: move api into peer dependency
Flarna Jun 4, 2021
101304c
fix peer-api-check script
Flarna Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/peer-api.yaml
View file
Open in desktop
@@ -0,0 +1,22 @@
name: Ensure API Peer Dependency

on:
push:
branches:
- main
pull_request:

jobs:
peer-api-check:
runs-on: ubuntu-latest
container:
image: node:14
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Install lerna
run: npm install -g lerna

- name: Check API dependency semantics
run: lerna exec "node \$LERNA_ROOT_PATH/scripts/peer-api-check.js"
5 changes: 4 additions & 1 deletion detectors/node/opentelemetry-resource-detector-github/package.json
View file
Open in desktop
Expand Up @@ -42,7 +42,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@types/mocha": "8.2.2",
"@types/node": "14.17.2",
"@types/sinon": "9.0.11",
Expand All @@ -56,7 +60,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/resources": "^0.20.0"
}
}
5 changes: 4 additions & 1 deletion metapackages/auto-instrumentations-node/package.json
View file
Open in desktop
Expand Up @@ -26,7 +26,11 @@
"bugs": {
"url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@types/mocha": "7.0.2",
"@types/node": "14.17.2",
"@types/sinon": "9.0.11",
Expand All @@ -40,7 +44,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/instrumentation-dns": "^0.20.0",
"@opentelemetry/instrumentation-express": "^0.20.0",
Expand Down
5 changes: 4 additions & 1 deletion metapackages/auto-instrumentations-web/package.json
View file
Open in desktop
Expand Up @@ -27,8 +27,12 @@
"bugs": {
"url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@babel/core": "7.14.3",
"@opentelemetry/api": "0.20.0",
"@types/mocha": "8.2.2",
"@types/node": "14.17.2",
"@types/sinon": "9.0.11",
Expand All @@ -55,7 +59,6 @@
"webpack-merge": "5.7.3"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/instrumentation-document-load": "^0.20.0",
"@opentelemetry/instrumentation-fetch": "^0.20.0",
Expand Down
5 changes: 4 additions & 1 deletion packages/opentelemetry-host-metrics/package.json
View file
Open in desktop
Expand Up @@ -41,7 +41,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@types/mocha": "8.2.2",
"@types/node": "14.17.2",
"@types/sinon": "9.0.11",
Expand All @@ -55,7 +59,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/api-metrics": "^0.20.0",
"@opentelemetry/core": "^0.20.0",
"@opentelemetry/metrics": "^0.20.0",
Expand Down
5 changes: 4 additions & 1 deletion packages/opentelemetry-id-generator-aws-xray/package.json
View file
Open in desktop
Expand Up @@ -51,7 +51,11 @@
"LICENSE",
"README.md"
],
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@types/mocha": "8.2.2",
"@types/node": "14.17.2",
"@types/sinon": "9.0.11",
Expand All @@ -75,7 +79,6 @@
"webpack": "4.46.0"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/core": "^0.20.0"
}
}
9 changes: 6 additions & 3 deletions packages/opentelemetry-test-utils/package.json
View file
Open in desktop
Expand Up @@ -23,14 +23,17 @@
"url": "https://github.com/open-telemetry/opentelemetry-js/issues"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js#readme",
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@types/node": "14.17.2",
"gts": "3.1.0",
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/core": "0.20.0",
"@opentelemetry/tracing": "0.20.0"
"@opentelemetry/core": "^0.20.0",
"@opentelemetry/tracing": "^0.20.0"
}
}
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-aws-lambda/package.json
View file
Open in desktop
Expand Up @@ -40,7 +40,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/core": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@types/mocha": "7.0.2",
Expand All @@ -54,7 +58,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/propagator-aws-xray": "^0.20.0",
"@opentelemetry/resources": "^0.20.0",
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-bunyan/package.json
View file
Open in desktop
Expand Up @@ -41,7 +41,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/context-async-hooks": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
Expand All @@ -59,7 +63,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@types/bunyan": "1.8.6"
}
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-dns/package.json
View file
Open in desktop
Expand Up @@ -40,7 +40,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/core": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
Expand All @@ -59,7 +63,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0",
"semver": "^7.3.2"
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-express/package.json
View file
Open in desktop
Expand Up @@ -41,7 +41,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/context-async-hooks": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
Expand All @@ -57,7 +61,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/core": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0",
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-generic-pool/package.json
View file
Open in desktop
Expand Up @@ -40,7 +40,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/context-async-hooks": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
Expand All @@ -58,7 +62,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0",
"@types/generic-pool": "^3.1.9"
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-graphql/package.json
View file
Open in desktop
Expand Up @@ -42,7 +42,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
"@types/mocha": "8.2.2",
"@types/node": "14.17.2",
Expand All @@ -56,7 +60,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@types/graphql": "14.5.0"
}
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-hapi/package.json
View file
Open in desktop
Expand Up @@ -40,8 +40,12 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@hapi/hapi": "20.1.3",
"@opentelemetry/api": "0.20.0",
"@opentelemetry/context-async-hooks": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
Expand All @@ -57,7 +61,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0",
"@types/hapi__hapi": "20.0.8"
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-ioredis/package.json
View file
Open in desktop
Expand Up @@ -43,7 +43,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/context-async-hooks": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/test-utils": "^0.20.0",
Expand All @@ -61,7 +65,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0",
"@types/ioredis": "4.26.4"
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-koa/package.json
View file
Open in desktop
Expand Up @@ -42,8 +42,12 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@koa/router": "9.4.0",
"@opentelemetry/api": "0.20.0",
"@opentelemetry/context-async-hooks": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
Expand All @@ -59,7 +63,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/core": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0",
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-mongodb/package.json
View file
Open in desktop
Expand Up @@ -42,7 +42,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/context-async-hooks": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
Expand All @@ -58,7 +62,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0",
"@types/mongodb": "3.6.17"
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-mysql/package.json
View file
Open in desktop
Expand Up @@ -40,7 +40,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/context-async-hooks": "0.20.0",
"@opentelemetry/test-utils": "^0.20.0",
"@opentelemetry/tracing": "0.20.0",
Expand All @@ -56,7 +60,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0",
"@types/mysql": "2.15.18"
Expand Down
5 changes: 4 additions & 1 deletion plugins/node/opentelemetry-instrumentation-net/package.json
View file
Open in desktop
Expand Up @@ -41,7 +41,11 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@opentelemetry/api": "^0.20.0"
},
"devDependencies": {
"@opentelemetry/api": "0.20.0",
"@opentelemetry/node": "0.20.0",
"@opentelemetry/tracing": "0.20.0",
"@types/mocha": "7.0.2",
Expand All @@ -57,7 +61,6 @@
"typescript": "4.3.2"
},
"dependencies": {
"@opentelemetry/api": "^0.20.0",
"@opentelemetry/instrumentation": "^0.20.0",
"@opentelemetry/semantic-conventions": "^0.20.0"
}
Expand Down