Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable typescript 4.3 option noImplicitOverride #549

Merged
merged 11 commits into from Jul 12, 2021
Merged

chore: enable typescript 4.3 option noImplicitOverride #549

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
75a4a24
chore: enable typescript 4.3 option noImplicitOverride
Flarna Jun 5, 2021
5b99f79
Merge branch 'main' into ts-override
Flarna Jun 28, 2021
362023d
Merge branch 'main' into ts-override
Flarna Jun 30, 2021
945ad02
chore: update memcached
Flarna Jun 30, 2021
78542e6
Merge remote-tracking branch 'upstream/main' into ts-override
Flarna Jun 30, 2021
fe8bcbb
chore: update after merge from main
Flarna Jun 30, 2021
4bd8f20
Merge remote-tracking branch 'upstream/main' into ts-override
Flarna Jul 1, 2021
afb2f2c
Merge branch 'main' into ts-override
Flarna Jul 1, 2021
b0cdfd8
Merge branch 'main' into ts-override
Flarna Jul 2, 2021
26b6f76
Merge branch 'main' into ts-override
Flarna Jul 2, 2021
f87ae51
Merge branch 'main' into ts-override
Flarna Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@
# JavaScript, TypeScript, c, and h source files
*.js text eol=lf
*.ts text eol=lf
*.tsx text eol=lf
*.h text eol=lf diff=cpp
*.c text eol=lf diff=cpp

Expand Down
2 changes: 1 addition & 1 deletion detectors/node/opentelemetry-resource-detector-github/package.json
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@
"rimraf": "3.0.2",
"sinon": "10.0.0",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/resources": "^0.22.0"
Expand Down
2 changes: 1 addition & 1 deletion metapackages/auto-instrumentations-node/package.json
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@
"rimraf": "3.0.2",
"sinon": "10.0.0",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion metapackages/auto-instrumentations-web/package.json
View file
Open in desktop
Expand Up @@ -53,7 +53,7 @@
"sinon": "10.0.0",
"ts-loader": "8.3.0",
"ts-mocha": "8.0.0",
"typescript": "4.3.2",
"typescript": "4.3.4",
"webpack": "4.46.0",
"webpack-cli": "4.7.2",
"webpack-merge": "5.8.0"
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Expand Up @@ -42,17 +42,17 @@
"devDependencies": {
"@commitlint/cli": "11.0.0",
"@commitlint/config-conventional": "11.0.0",
"@typescript-eslint/eslint-plugin": "4.26.1",
"@typescript-eslint/parser": "4.26.1",
"eslint": "7.28.0",
"@typescript-eslint/eslint-plugin": "4.28.0",
"@typescript-eslint/parser": "4.28.0",
"eslint": "7.29.0",
"eslint-config-airbnb-base": "14.2.1",
"eslint-plugin-header": "3.1.1",
"eslint-plugin-import": "2.23.4",
"gts": "3.1.0",
"husky": "4.3.8",
"lerna": "3.22.1",
"lerna-changelog": "1.0.1",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"husky": {
"hooks": {
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-host-metrics/package.json
View file
Open in desktop
Expand Up @@ -56,7 +56,7 @@
"rimraf": "3.0.2",
"sinon": "10.0.0",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/api-metrics": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-id-generator-aws-xray/package.json
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@
"sinon": "10.0.0",
"ts-loader": "8.3.0",
"ts-mocha": "8.0.0",
"typescript": "4.3.2",
"typescript": "4.3.4",
"webpack": "4.46.0"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-test-utils/package.json
View file
Open in desktop
Expand Up @@ -30,7 +30,7 @@
"@opentelemetry/api": "1.0.0",
"@types/node": "14.17.3",
"gts": "3.1.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/core": "0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-aws-lambda/package.json
View file
Open in desktop
Expand Up @@ -55,7 +55,7 @@
"nyc": "15.1.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
6 changes: 3 additions & 3 deletions plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -71,11 +71,11 @@ export const traceContextEnvironmentKey = '_X_AMZN_TRACE_ID';
export class AwsLambdaInstrumentation extends InstrumentationBase {
private _tracerProvider: TracerProvider | undefined;

constructor(protected _config: AwsLambdaInstrumentationConfig = {}) {
constructor(protected override _config: AwsLambdaInstrumentationConfig = {}) {
Flarna marked this conversation as resolved.
Show resolved Hide resolved
super('@opentelemetry/instrumentation-aws-lambda', VERSION, _config);
}

setConfig(config: AwsLambdaInstrumentationConfig = {}) {
override setConfig(config: AwsLambdaInstrumentationConfig = {}) {
this._config = config;
}

Expand Down Expand Up @@ -218,7 +218,7 @@ export class AwsLambdaInstrumentation extends InstrumentationBase {
};
}

setTracerProvider(tracerProvider: TracerProvider) {
override setTracerProvider(tracerProvider: TracerProvider) {
super.setTracerProvider(tracerProvider);
this._tracerProvider = tracerProvider;
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-bunyan/package.json
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@
"rimraf": "3.0.2",
"sinon": "9.2.4",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
4 changes: 2 additions & 2 deletions plugins/node/opentelemetry-instrumentation-bunyan/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -67,11 +67,11 @@ export class BunyanInstrumentation extends InstrumentationBase<
];
}

getConfig(): BunyanInstrumentationConfig {
override getConfig(): BunyanInstrumentationConfig {
return this._config;
}

setConfig(config: BunyanInstrumentationConfig) {
override setConfig(config: BunyanInstrumentationConfig) {
this._config = config;
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-dns/package.json
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@
"rimraf": "3.0.2",
"sinon": "10.0.0",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-dns/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ import { VERSION } from './version';
* Dns instrumentation for Opentelemetry
*/
export class DnsInstrumentation extends InstrumentationBase<Dns> {
constructor(protected _config: DnsInstrumentationConfig = {}) {
constructor(protected override _config: DnsInstrumentationConfig = {}) {
super('@opentelemetry/instrumentation-dns', VERSION, _config);
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-express/package.json
View file
Open in desktop
Expand Up @@ -58,7 +58,7 @@
"nyc": "15.1.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/core": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-generic-pool/package.json
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@
"rimraf": "3.0.2",
"semver": "7.3.5",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-graphql/package.json
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@
"nyc": "15.1.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-graphql/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -77,7 +77,7 @@ export class GraphQLInstrumentation extends InstrumentationBase {
return this._config as GraphQLInstrumentationParsedConfig;
}

setConfig(config: GraphQLInstrumentationConfig & InstrumentationConfig = {}) {
override setConfig(config: GraphQLInstrumentationConfig = {}) {
this._config = Object.assign({}, DEFAULT_CONFIG, config);
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-hapi/package.json
View file
Open in desktop
Expand Up @@ -58,7 +58,7 @@
"rimraf": "3.0.2",
"semver": "7.3.5",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-ioredis/package.json
View file
Open in desktop
Expand Up @@ -62,7 +62,7 @@
"nyc": "15.1.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-knex/package.json
View file
Open in desktop
Expand Up @@ -58,7 +58,7 @@
"rimraf": "3.0.2",
"sqlite3": "5.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-koa/package.json
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@
"nyc": "15.1.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/core": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-mongodb/package.json
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@
"nyc": "15.1.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-mongodb/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -46,7 +46,7 @@ const supportedVersions = ['>=3.3 <4'];
export class MongoDBInstrumentation extends InstrumentationBase<
typeof mongodb
> {
constructor(protected _config: MongoDBInstrumentationConfig = {}) {
constructor(protected override _config: MongoDBInstrumentationConfig = {}) {
super('@opentelemetry/instrumentation-mongodb', VERSION, _config);
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-mysql/package.json
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@
"nyc": "15.1.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
4 changes: 2 additions & 2 deletions plugins/node/opentelemetry-instrumentation-mysql/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -36,8 +36,8 @@ export class MySQLInstrumentation extends InstrumentationBase<
[SemanticAttributes.DB_SYSTEM]: MySQLInstrumentation.COMPONENT,
};

constructor(protected _config: MySQLInstrumentationConfig = {}) {
super('@opentelemetry/instrumentation-mysql', VERSION, _config);
constructor(config?: MySQLInstrumentationConfig) {
super('@opentelemetry/instrumentation-mysql', VERSION, config);
}

protected init() {
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-mysql2/package.json
View file
Open in desktop
Expand Up @@ -58,7 +58,7 @@
"nyc": "15.1.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.2.4"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
4 changes: 2 additions & 2 deletions plugins/node/opentelemetry-instrumentation-mysql2/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -41,8 +41,8 @@ export class MySQL2Instrumentation extends InstrumentationBase<
[SemanticAttributes.DB_SYSTEM]: MySQL2Instrumentation.COMPONENT,
};

constructor(protected _config: MySQL2InstrumentationConfig = {}) {
super('@opentelemetry/instrumentation-mysql2', VERSION, _config);
constructor(config?: MySQL2InstrumentationConfig) {
super('@opentelemetry/instrumentation-mysql2', VERSION, config);
}

protected init() {
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-net/package.json
View file
Open in desktop
Expand Up @@ -58,7 +58,7 @@
"rimraf": "3.0.2",
"sinon": "10.0.0",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-net/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ import { Socket } from 'net';
import { TLSSocket } from 'tls';

export class NetInstrumentation extends InstrumentationBase<Net> {
constructor(protected _config: InstrumentationConfig = {}) {
constructor(_config?: InstrumentationConfig) {
super('@opentelemetry/instrumentation-net', VERSION, _config);
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-pg/package.json
View file
Open in desktop
Expand Up @@ -66,7 +66,7 @@
"pg-pool": "3.3.0",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-pino/package.json
View file
Open in desktop
Expand Up @@ -62,7 +62,7 @@
"sinon": "9.2.4",
"ts-mocha": "8.0.0",
"ts-node": "9.1.1",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
8 changes: 4 additions & 4 deletions plugins/node/opentelemetry-instrumentation-pino/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -82,20 +82,20 @@ export class PinoInstrumentation extends InstrumentationBase {
];
}

getConfig(): PinoInstrumentationConfig {
override getConfig(): PinoInstrumentationConfig {
return this._config;
}

setConfig(config: PinoInstrumentationConfig) {
override setConfig(config: PinoInstrumentationConfig) {
this._config = config;
}

enable() {
override enable() {
super.enable();
this._isEnabled = true;
}

disable() {
override disable() {
super.disable();
this._isEnabled = false;
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-redis/package.json
View file
Open in desktop
Expand Up @@ -61,7 +61,7 @@
"redis": "3.1.2",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
4 changes: 2 additions & 2 deletions plugins/node/opentelemetry-instrumentation-redis/src/instrumentation.ts
View file
Open in desktop
Expand Up @@ -38,11 +38,11 @@ export class RedisInstrumentation extends InstrumentationBase<
> {
static readonly COMPONENT = 'redis';

constructor(protected _config: RedisInstrumentationConfig = {}) {
constructor(protected override _config: RedisInstrumentationConfig = {}) {
super('@opentelemetry/instrumentation-redis', VERSION, _config);
}

setConfig(config: RedisInstrumentationConfig = {}) {
override setConfig(config: RedisInstrumentationConfig = {}) {
this._config = Object.assign({}, DEFAULT_CONFIG, config);
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-restify/package.json
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@
"restify": "4.3.4",
"rimraf": "3.0.2",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/core": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-router/package.json
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@
"rimraf": "3.0.2",
"router": "1.3.5",
"ts-mocha": "8.0.0",
"typescript": "4.3.2"
"typescript": "4.3.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-winston/package.json
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@
"rimraf": "3.0.2",
"sinon": "9.2.4",
"ts-mocha": "8.0.0",
"typescript": "4.3.2",
"typescript": "4.3.4",
"winston": "3.3.3",
"winston2": "npm:winston@2.4.5"
},
Expand Down