Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: use single quotes everywhere and add a rule to eslint #583

Merged
merged 2 commits into from Jul 26, 2021
Merged

style: use single quotes everywhere and add a rule to eslint #583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fda9913
style: use single quotes everywhere and add a rule to eslint
CptSchnitz Jul 20, 2021
505dfb7
Merge branch 'main' into issue-582
vmarchaud Jul 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.js
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ module.exports = {
"project": "./tsconfig.json"
},
rules: {
"quotes": [2, "single", { "avoidEscape": true }],
"@typescript-eslint/no-this-alias": "off",
"eqeqeq": "off",
"prefer-rest-params": "off",
Expand Down
2 changes: 1 addition & 1 deletion metapackages/auto-instrumentations-web/README.md
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ registerInstrumentations({
instrumentations: [
getWebAutoInstrumentations({
// load custom configuration for xml-http-request instrumentation
"@opentelemetry/instrumentation-xml-http-request": {
'@opentelemetry/instrumentation-xml-http-request': {
clearTimingResources: true,
},
}),
Expand Down
6 changes: 3 additions & 3 deletions plugins/node/opentelemetry-instrumentation-ioredis/README.md
View file
Open in desktop
Expand Up @@ -25,11 +25,11 @@ npm install --save @opentelemetry/instrumentation-ioredis
To load a specific instrumentation (**ioredis** in this case), specify it in the registerInstrumentations's configuration

```javascript
const { NodeTracerProvider } = require("@opentelemetry/node");
const { NodeTracerProvider } = require('@opentelemetry/node');
const {
IORedisInstrumentation,
} = require("@opentelemetry/instrumentation-ioredis");
const { registerInstrumentations } = require("@opentelemetry/instrumentation");
} = require('@opentelemetry/instrumentation-ioredis');
const { registerInstrumentations } = require('@opentelemetry/instrumentation');

const provider = new NodeTracerProvider();
provider.register();
Expand Down
2 changes: 1 addition & 1 deletion propagators/opentelemetry-propagator-grpc-census-binary/README.md
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ Example of usage:

```javascript
const { NodeTracerProvider } = require('@opentelemetry/node');
const { GrpcCensusPropagator } = require("@opentelemetry/propagator-grpc-census-binary");
const { GrpcCensusPropagator } = require('@opentelemetry/propagator-grpc-census-binary');
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
const { GrpcInstrumentation } = require('opentelemetry/instrumentation-grpc');

Expand Down
2 changes: 1 addition & 1 deletion scripts/version-update.js
View file
Open in desktop
Expand Up @@ -43,6 +43,6 @@ const content = `/*
export const VERSION = '${pjson.version}';
`;

const fileUrl = path.join(appRoot, "src", "version.ts")
const fileUrl = path.join(appRoot, 'src', 'version.ts')

fs.writeFileSync(fileUrl, content);