New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency eslint to v8 #699
Merged
blumamir
merged 7 commits into
open-telemetry:main
from
renovate-bot:renovate/eslint-8.x
Jan 31, 2022
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1359c69
chore(deps): update dependency eslint to v8
renovate-bot 995b62f
Merge branch 'main' into renovate/eslint-8.x
1ba53ef
Merge branch 'main' into renovate/eslint-8.x
ab174ca
Merge branch 'main' into renovate/eslint-8.x
vmarchaud c32d203
Merge branch 'main' into renovate/eslint-8.x
eee58a5
Merge branch 'main' into renovate/eslint-8.x
9220bc5
Merge branch 'main' into renovate/eslint-8.x
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to the version bump, but should we remove
eslint
dependency and other eslint related packages from the subpackages, and keep it only in root?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we can since the deps aren't hoisted, this would mean that you couldn't run eslint independently for a specific repo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency is only specified on
browser-extension-autoinject
andinstrumentation-aws-sdk
.If it's needed per package then we should also add it to all other packages in the repo, but I think it's better to configure and run lint on the entire repo from the root, and not per package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browser-extension-autoinject
useeslint-plugin-json5
.I believe it can be hoisted to the repo root.