Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of semantic conventions to new exported strings #4567

Open
2 of 24 tasks
Tracked by #4572
JamieDanielson opened this issue Mar 21, 2024 · 4 comments
Open
2 of 24 tasks
Tracked by #4572

Update usage of semantic conventions to new exported strings #4567

JamieDanielson opened this issue Mar 21, 2024 · 4 comments
Labels
good first issue Good for newcomers needs:code-contribution This feature/bug is ready to implement type:feature-tracking A feature with sub-issues that need to be addressed up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@JamieDanielson
Copy link
Member

JamieDanielson commented Mar 21, 2024 •
edited

Same as open-telemetry/opentelemetry-js-contrib#2025 for core repo.

This issue is intended to track the necessary change of updating each package to use the new exports for semantic conventions that were added in #4298 and now available in v1.22.0.

Each package will need to

  • update the dependency for @opentelemetry/semantic-conventions to "^1.22.0"
  • update the imported semantic convention to match the new version, i.e. HTTP_ROUTE becomes SEMATTRS_HTTP_ROUTE

Please limit PRs to a single package in order to make them quickly and easily reviewable.
If you are working on one of the below packages, please comment so others know the issue is being worked on.
@JamieDanielson JamieDanielson added good first issue Good for newcomers type:feature-tracking A feature with sub-issues that need to be addressed up-for-grabs Good for taking. Extra help will be provided by maintainers needs:code-contribution This feature/bug is ready to implement labels Mar 21, 2024
This was referenced Mar 21, 2024
Open
Merged
@JamieDanielson
Copy link
Member Author

I am working on http package

@mmouru mmouru mentioned this issue Apr 14, 2024
Open
5 tasks
@mmouru
Copy link
Contributor

mmouru commented Apr 14, 2024

PR for instrumentation-fetch #4632

@mmouru mmouru mentioned this issue Apr 14, 2024
Merged
5 tasks
@Prashansa-K
Copy link

@JamieDanielson Can I also contribute in this issue? I can start working on this package - @opentelemetry/instrumentation-xml-http-request if no one has picked this up yet.

@Prashansa-K Prashansa-K mentioned this issue May 6, 2024
Open
5 tasks
@Prashansa-K
Copy link

Created a PR for instrumentation-xhr here: #4681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers needs:code-contribution This feature/bug is ready to implement type:feature-tracking A feature with sub-issues that need to be addressed up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JamieDanielson @Prashansa-K @mmouru