refactor(instr-fetch): move fetch to use SEMATRR #4632
+50
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
24 tasks
|
Hi @mmouru thanks for contributing into our effort to update semantic conventions. 🎉 Would you please complete this PR by adding a section in the README file listing the attributes used in this instrumentation? You can have a look at intrumentation-http README |
pichlermarc
reviewed
May 3, 2024
experimental/CHANGELOG.md
Outdated
Comment on lines
18
to
55
| * refactor(instr-fetch): move fetch to use SEMATRR [#4632](https://github.com/open-telemetry/opentelemetry-js/pull/4632) | ||
|
|
There was a problem hiding this comment.
Suggested change
| * refactor(instr-fetch): move fetch to use SEMATRR [#4632](https://github.com/open-telemetry/opentelemetry-js/pull/4632) | |
| * refactor(instrumentation-fetch): move fetch to use SEMATRR [#4632](https://github.com/open-telemetry/opentelemetry-js/pull/4632) |
|
Thank you @mmouru for your contribution :) Would you please add a section in the README file listing the attributes used in this instrumentation? Here is an example (you can omit the 3rd column) https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-http#semantic-conventions |
mmouru
force-pushed
the
fetch-semconv
branch
6 times, most recently
from
17240f3
to
301a207
Compare
|
done my bits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates #4567
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: