Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exponential histogram - part 3 - export #3506

Merged
merged 5 commits into from Mar 28, 2023

Conversation

mwear
Copy link
Member

@mwear mwear commented Dec 22, 2022

Which problem is this PR solving?

This PR is part 3 in a series of PRs to add exponential histogram support. See this comparison introduced by this PR (omitting those from Part 1 and Part 2).

Partially Fixes #3324

Short description of the changes

This PRs addresses the final details to wire up exponential histogram export to OTLP.

This code is heavily based on the Golang reference implementation. For other details see:

For the other PRs in this series see:

You can see all 3 PRs combined in the original draft PR

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Extensive unit testing
  • End to end test with the 3 PRs from this series adding ExponentialHistogram support

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #3506 (da35d43) into main (dbe005f) will increase coverage by 0.04%.
The diff coverage is 75.00%.

❗ Current head da35d43 differs from pull request most recent head 8887055. Consider uploading reports for the commit 8887055 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3506      +/-   ##
==========================================
+ Coverage   93.61%   93.66%   +0.04%     
==========================================
  Files         274      277       +3     
  Lines        8197     8462     +265     
  Branches     1691     1756      +65     
==========================================
+ Hits         7674     7926     +252     
- Misses        523      536      +13     
Impacted Files Coverage Δ
...tal/packages/otlp-transformer/src/metrics/types.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/view/Aggregation.ts 93.82% <55.55%> (-4.79%) ⬇️
.../packages/otlp-transformer/src/metrics/internal.ts 98.00% <100.00%> (+0.27%) ⬆️
packages/sdk-metrics/src/aggregator/index.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

CHANGELOG.md Outdated
Comment on lines 14 to 15
* feat(sdk-metrics): exponential histogram export [#3506](https://github.com/open-telemetry/opentelemetry-js/pull/3506) @mwear
* feat(sdk-metrics): add exponential histogram accumulation / aggregator [#3505](https://github.com/open-telemetry/opentelemetry-js/pull/3505) @mwear
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably combine these changelog entries into one more user-friendly one that references both PRs since this release actually makes this feature available.

@@ -184,7 +184,7 @@ export interface IExponentialHistogramDataPoint {
startTimeUnixNano?: number;

/** ExponentialHistogramDataPoint timeUnixNano */
timeUnixNano?: string;
timeUnixNano?: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a mistake that got through before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an existing issue on main that predates my work on the exponential histogram.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for putting in all the effort to implement this. 🙂🚀

@pichlermarc
Copy link
Member

Failing tests are unrelated to this PR, see #3700

@pichlermarc pichlermarc merged commit 8c78859 into open-telemetry:main Mar 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Exponential Histograms
3 participants