Bump stimulus_reflex to 3.5.0-rc4 and cable_ready to 5.0.3 #12235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacook
added
technical changes only
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dacook
added
pr-staged-uk
4 tasks
dacook
force-pushed
the
cable_ready-update
branch
from
2276b55
to
a3c239a
Compare
|
Yay, after upgrading stimulus_reflex, this now works! |
dacook
added
dependencies
javascript
dacook
changed the title
dacook
force-pushed
the
cable_ready-update
branch
from
a3c239a
to
c4df318
Compare
|
Does this need testing? Maybe checking reports? |
|
Yes, I think it should be treated the same as #12260 , which is awaiting testing, but also lacking test notes. |
Bumps [stimulus_reflex](https://github.com/stimulusreflex/stimulus_reflex) from 3.5.0-rc3 to 3.5.0-rc4. - [Release notes](https://github.com/stimulusreflex/stimulus_reflex/releases) - [Changelog](https://github.com/stimulusreflex/stimulus_reflex/blob/main/CHANGELOG.md) - [Commits](https://github.com/stimulusreflex/stimulus_reflex/commits) --- updated-dependencies: - dependency-name: stimulus_reflex dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Gem and package need to be in sync.
Unfortunately the testing framework doesn't support the latest version of StimulusReflex. This is a third party framework that doesn't seem to be maintained. Maybe we should convert these to ActionCable tests.
It contains a fix for stimulus_reflex 3.5.0-rc4, but hasn't been released yet. podia/stimulus_reflex_testing#21 Now the user reflex spec works, but the products spec needs another fix. But we plan to remove it soon anyway.
In order to match installed js package version. For some reason, it still reports js package as 5.0.1..
I don't know why cable_ready@^5.0.0 would resolve to v5.0.2, when v5.0.3 is available. So I gave yarn a bit of a nudge in the right direction. It installs fine now.
dacook
force-pushed
the
cable_ready-update
branch
from
c4df318
to
b7092a5
Compare
dacook
changed the title
|
Oh, yes thanks. That's weird, I don't know how I missed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main(because latest fixes haven't been released yet).What should we test?
These are underlying frameworks used for the dynamic functionality on the below pages. Simply checking that they work as usual, with no errors in the dev console should be sufficient.
/admin/productswithadmin_style_v3)/admin/reports/packing/customer(old or new design, doesn't matter)Dependencies