chore(deps): bump stimulus_reflex from 3.5.0-rc3 to 3.5.0-rc4

[dependabot]

• Bumps stimulus_reflex ruby gem and JS package from 3.5.0-rc3 to 3.5.0-rc4.
• Disables StimulusReflex specs, due to below issue

What should we test?

This is the underlying framework used for the dynamic functionality used on the below pages. Simply checking that they work as usual, with no errors in the dev console should be sufficient.

• BUU Bulk Edit Products (/admin/products with admin_style_v3)
• A report, eg /admin/reports/packing/customer (old or new design, doesn't matter)

After this one, please stage the next PR which has the same test requirements: #12235

---

Commits

• See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Dependencies

• Specs won't work until Fix compatibility with stimulus_reflex 3.5.0.rc4 podia/stimulus_reflex_testing#21

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[rioug]

@dacook do you want to test this before merging ?

[dacook]

Hmm, at least one of the fixes sounds promising, I wonder if that will help with any of our problems:

https://github.com/stimulusreflex/stimulus_reflex/releases/tag/v3.5.0.rc4

• Fix exception in ActionCable channel due to reflexes overwriting each other's data by @alexander-makarenko in Fix exception in ActionCable channel due to reflexes overwriting each other's data stimulusreflex/stimulus_reflex#663

It was actually fixed in Sept last year, so it's a bit concerning that it took so long to release. Even more concerning that SR has only been released as a "release candidate" for a very long time now; what's holding it back I wonder?

So anyway, yeah I reckon we should test it. I would just go for general usability with the main SR screens:

• v3 bulk edit products
• bulk orders

[drummer83]

So anyway, yeah I reckon we should test it. I would just go for general usability with the main SR screens:

• v3 bulk edit products

• bulk orders

@dacook
I'm asuming that 'bulk orders' means the bulk order actions like mentioned here in 'What should we test'?

I will go ahead and test this and then park it until your confirmation.

[drummer83]

Hi @dacook,

After staging we get a warning about a version mismatch. Is this somehting we have to look into?

Order list, bulk actions:

Bulk editing of products:
Same warning for Admin Style v3 only.

Adding feedback-needed label and waiting for your comment.

Thanks!

[dacook]

Thanks for pointing this out @drummer83 . I've now upgraded the gem, and found that this will unlock another JS upgrade. Yay!

Oh, but the third-party testing framework we use doesn't work with this version yet... Back to the drawing board..

[dacook]

Disabled StimulusReflex specs temporarily.
Unfortunately the testing framework doesn't support the latest version of StimulusReflex.
This is a third party framework that doesn't seem to be maintained. Maybe we should convert these to ActionCable tests.

[sigmundpetersen]

There was a fix merged podia/stimulus_reflex_testing#22

I guess it's not a long term solution though...

[dacook]

Thanks, that might be worth using because the user_reflex_spec.rb will still be relevant, at least in the medium-term.

But I will pause this for now, until our usage of SR settles down.

Next steps:

• Wait until [BUU] [Infinite loader] - Remove Stimulus Reflex from Products Page #12331 is resolved
• Maybe also wait for [Background reports] Infinite loader #11752
• Consider combining this PR with Bump stimulus_reflex to 3.5.0-rc4 and cable_ready to 5.0.3 #12235 to save on manual testing time
• Evaluate all areas of the codebase that are using either StimulusReflex or CableReady
  • Write up testing notes for both

[dependabot]

A newer version of stimulus_reflex exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[dacook]

I'm pulling this from testing, because it's now superseded by #12472. Let's not waste time testing both.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.