Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRVCLI-401: 馃Ч Makefile for auto-discover of tests #401

Merged
merged 1 commit into from May 15, 2024

Conversation

cardil
Copy link
Member

@cardil cardil commented May 10, 2024

Changes

  • 馃Ч Makefile for tests auto-discover via openshift-knative/hack

Part of SRVCLI-401

/kind enhancement

@openshift-ci-robot
Copy link

@cardil: This pull request references SRVCLI-401 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Changes

  • 馃挐 Makefile for tests auto-discover via openshift-knative/hack

Part of SRVCLI-401

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label May 10, 2024
@openshift-ci openshift-ci bot requested review from lkingland and mgencur May 10, 2024 18:46
@cardil
Copy link
Member Author

cardil commented May 10, 2024

/cherrypick release-1.11
/cherrypick release-1.13
/cherrypick release-1.14

@openshift-cherrypick-robot

@cardil: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.11
/cherrypick release-1.13
/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Member Author

cardil commented May 10, 2024

/cherrypick release-1.11 release-1.13 release-1.14

@openshift-cherrypick-robot

@cardil: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.11 release-1.13 release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Member Author

cardil commented May 10, 2024

/cherrypick release-1.13

@openshift-cherrypick-robot

@cardil: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Member Author

cardil commented May 10, 2024

/cherrypick release-1.14

@openshift-cherrypick-robot

@cardil: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Member Author

cardil commented May 10, 2024

/kind cleanup

@cardil cardil removed the kind/enhancement New feature or request label May 10, 2024
@cardil cardil changed the title SRVCLI-401: 馃挐 Makefile for tests auto-discover via openshift-knative/hack SRVCLI-401: 馃Ч Makefile for tests auto-discover via openshift-knative/hack May 10, 2024
@cardil cardil changed the title SRVCLI-401: 馃Ч Makefile for tests auto-discover via openshift-knative/hack SRVCLI-401: 馃Ч Makefile for auto-discover of tests May 10, 2024
Copy link

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bcd5f3b into openshift-knative:main May 15, 2024
1 check passed
@openshift-cherrypick-robot

@cardil: new pull request created: #405

In response to this:

/cherrypick release-1.11 release-1.13 release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@cardil: new pull request created: #406

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@cardil: new pull request created: #407

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants