-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate CI supports patch versions #2641
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -10,6 +10,9 @@ on: | |||
branch: | ||||
required: true | ||||
description: "SO branch" | ||||
tag: | ||||
required: true | ||||
description: "Promotion tag" | ||||
|
||||
jobs: | ||||
generate-ci: | ||||
|
@@ -51,12 +54,17 @@ jobs: | |||
- name: Generate CI (on workflow dispatch) | ||||
if: github.event_name == 'workflow_dispatch' | ||||
working-directory: ./src/github.com/openshift-knative/hack | ||||
run: go run ./cmd/prowcopy --branch ${{ inputs.branch }} --tag ${{ inputs.branch }} --config config/serverless-operator.yaml | ||||
run: go run ./cmd/prowcopy --branch ${{ inputs.branch }} --tag ${{ inputs.tag }} --config config/serverless-operator.yaml | ||||
|
||||
- name: Generate CI (on branch created) | ||||
if: github.event.created | ||||
working-directory: ./src/github.com/openshift-knative/hack | ||||
run: go run ./cmd/prowcopy --branch ${{ github.ref_name }} --tag ${{ github.ref_name }} --config config/serverless-operator.yaml | ||||
run: go run ./cmd/prowcopy --branch ${{ github.ref_name }} --tag "release-$(yq read ../serverless-operator/olm-catalog/serverless-operator/project.yaml 'project.version') --config config/serverless-operator.yaml | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we have yq installed at this point?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a step There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome 🎉 |
||||
|
||||
- name: Generate CI (on push) | ||||
if: github.event.created == false | ||||
working-directory: ./src/github.com/openshift-knative/hack | ||||
run: go run ./cmd/prowcopy --from-branch ${{ github.ref_name }} --branch ${{ github.ref_name }} --tag "release-$(yq read ../serverless-operator/olm-catalog/serverless-operator/project.yaml 'project.version') --config config/serverless-operator.yaml | ||||
|
||||
- name: Create Pull Request | ||||
uses: peter-evans/create-pull-request@v6 | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not call it with:
(or with
@main
if we don't keep track of thegithub.com/openshift-knative/hack/cmd/prowcopy
in go.mod)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same as before, I don't think it's related to this change and can be "improved" as a follow up?