Generate CI supports patch versions #2641
Conversation
When creating a new branch or updating a patch version for a release branch, we will run the automation to regenarate the CI config and update the promotion tag according to `project.yaml` version Depends on openshift-knative/hack#153 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
/cc @mgencur |
| @@ -51,12 +54,17 @@ jobs: | |||
| - name: Generate CI (on workflow dispatch) | |||
| if: github.event_name == 'workflow_dispatch' | |||
| working-directory: ./src/github.com/openshift-knative/hack | |||
| run: go run ./cmd/prowcopy --branch ${{ inputs.branch }} --tag ${{ inputs.branch }} --config config/serverless-operator.yaml | |||
| run: go run ./cmd/prowcopy --branch ${{ inputs.branch }} --tag ${{ inputs.tag }} --config config/serverless-operator.yaml | |||
There was a problem hiding this comment.
Why not call it with:
go run github.com/openshift-knative/hack/cmd/prowcopy
(or with @main if we don't keep track of the github.com/openshift-knative/hack/cmd/prowcopy in go.mod)
There was a problem hiding this comment.
This is the same as before, I don't think it's related to this change and can be "improved" as a follow up?
|
|
||
| - name: Generate CI (on branch created) | ||
| if: github.event.created | ||
| working-directory: ./src/github.com/openshift-knative/hack | ||
| run: go run ./cmd/prowcopy --branch ${{ github.ref_name }} --tag ${{ github.ref_name }} --config config/serverless-operator.yaml | ||
| run: go run ./cmd/prowcopy --branch ${{ github.ref_name }} --tag "release-$(yq read ../serverless-operator/olm-catalog/serverless-operator/project.yaml 'project.version') --config config/serverless-operator.yaml |
There was a problem hiding this comment.
Do we have yq installed at this point?
Just wondering, because here we "download" it:
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.33 |
|
@pierDipi: new pull request created: #2644 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When creating a new branch or updating a patch version for a release branch, we will run the automation to regenarate the CI config and update the promotion tag according to
project.yamlversionDepends on openshift-knative/hack#153