Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-10291: CCM as optional capability #75877

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OSDOCS-10291: CCM as optional capability #75877

wants to merge 2 commits into from

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented May 13, 2024 •
edited

Version(s):
4.16+

Issue:
OSDOCS-10291

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Also fixed CCM name in a couple places

@jeana-redhat jeana-redhat added this to the Planned for 4.16 GA milestone May 13, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot

@jeana-redhat: This pull request references OSDOCS-10291 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
OSDOCS-10291

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Also fixed CCM name in a couple places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

2 similar comments
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot

@jeana-redhat: This pull request references OSDOCS-10291 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
OSDOCS-10291

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Also fixed CCM name in a couple places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot

@jeana-redhat: This pull request references OSDOCS-10291 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
OSDOCS-10291

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Also fixed CCM name in a couple places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 13, 2024 •
edited

🤖 Thu May 23 13:22:34 - Prow CI generated the docs preview:
https://75877--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot

@jeana-redhat: This pull request references OSDOCS-10291 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
OSDOCS-10291

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Also fixed CCM name in a couple places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeana-redhat jeana-redhat mentioned this pull request May 13, 2024
Open
1 task
@sunzhaohua2
Copy link

@jeana-redhat may need to add a note "You can disable this capability only for non cloud platforms or External type with cloudControllerManager state None"

@jeana-redhat jeana-redhat force-pushed the OSDOCS-10291-composable-ocp-cloud-controller-manager branch from 74916c1 to 50d9632 Compare May 16, 2024 13:29
@jeana-redhat
Copy link
Contributor Author

@qJkee can you please take a look at the docs for your work on CCM as an optional capability in 4.16?

@qJkee
Copy link

qJkee commented May 20, 2024

/cc

@openshift-ci openshift-ci bot requested a review from qJkee May 20, 2024 05:40
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2024 •
edited by openshift-ci bot

@jeana-redhat: This pull request references OSDOCS-10291 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
OSDOCS-10291

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Also fixed CCM name in a couple places

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeana-redhat jeana-redhat force-pushed the OSDOCS-10291-composable-ocp-cloud-controller-manager branch from 50d9632 to 711ae65 Compare May 20, 2024 14:43
@jeana-redhat jeana-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label May 20, 2024
mletalie
mletalie reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 20, 2024
mletalie
mletalie reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-needed
/label peer-review-done
/lgtm
/remove-label peer-review-in-progress

modules/cluster-cloud-controller-manager-operator.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 20, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@mletalie
Copy link
Contributor

mletalie commented May 20, 2024 •
edited

/lgtm...just had one comment....
Great job on this, @jeana-redhat!

@jeana-redhat jeana-redhat force-pushed the OSDOCS-10291-composable-ocp-cloud-controller-manager branch from 711ae65 to eba0202 Compare May 20, 2024 17:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@jeana-redhat jeana-redhat force-pushed the OSDOCS-10291-composable-ocp-cloud-controller-manager branch from eba0202 to 7bf4fe3 Compare May 23, 2024 09:15
@jeana-redhat
Copy link
Contributor Author

jeana-redhat commented May 23, 2024 •
edited

@sunzhaohua2 and @qJkee the new commit changes the process to determine whether CCM can be disabled from using the infrastructure resource to getting the info from the install-config.yaml file. PTAL when you have time 🙇

@sunzhaohua2
Copy link

LGTM

@qJkee
Copy link

qJkee commented May 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@jeana-redhat jeana-redhat force-pushed the OSDOCS-10291-composable-ocp-cloud-controller-manager branch from e1dc89f to 95fc94b Compare May 23, 2024 13:16
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 23, 2024

New changes are detected. LGTM label has been removed.

@jeana-redhat
Copy link
Contributor Author

/lgtm...just had one comment.... Great job on this, @jeana-redhat!

hey @mletalie, may I request a peek at the changes introduced with this commit?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 23, 2024

@jeana-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qJkee qJkee qJkee left review comments

@mletalie mletalie mletalie left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@qJkee qJkee

@mletalie mletalie

Labels
branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.16 GA
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jeana-redhat @openshift-ci-robot @ocpdocs-previewbot @sunzhaohua2 @qJkee @mletalie @ocpdocs-vale-bot