Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless cluster pool #49904

Merged
merged 3 commits into from Mar 20, 2024
Merged

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Mar 15, 2024

Create a new cluster pool that will be used by jobs under github.com/openshift-knative organization.

https://issues.redhat.com/browse/SRVCOM-3056

Followed the instructions from https://docs.ci.openshift.org/docs/how-tos/cluster-claim/#existing-cluster-pools
The platform credentials were prepared in Vault and this PR references them, specifically:

{
  "aws_access_key_id": "...",
  "aws_secret_access_key": "...",
  "secretsync/target-clusters": "hive",
  "secretsync/target-name": "serverless-aws-credentials",
  "secretsync/target-namespace": "serverless-cluster-pool"
}

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 15, 2024
@mgencur
Copy link
Contributor Author

mgencur commented Mar 15, 2024

Hmm, do we actually want OCP 4.15? Probably yes...

Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I got some questions.

@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

/hold

We want to have everything ready on Serverless side (prepare pull requests for using the cluster pool) before merging this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@mgencur mgencur changed the title [WIP] Serverless cluster pool Serverless cluster pool Mar 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@deepsm007
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

/unblock

@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit aff133e into openshift:master Mar 20, 2024
20 checks passed
@mgencur
Copy link
Contributor Author

mgencur commented Mar 20, 2024

@deepsm007 Thanks for review!

liswang89 pushed a commit to liswang89/release that referenced this pull request Mar 20, 2024
* Serverless cluster pool

* Use OCP 4.15 instead of 4.14

* Increase max size to 12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants