[olm] Store previous versions of olm manifests #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@varshaprasad96 how much larger is the stat --printf="%s\n" "$(command -v operator-sdk)"to check |
|
size of the binary after including bindata is ~69.32 MB, and SDK 1.0.0 binary is ~68.34 MB |
estroz
reviewed
Sep 17, 2020
estroz
reviewed
Sep 17, 2020
estroz
reviewed
Sep 17, 2020
hasbro17
reviewed
Sep 17, 2020
hasbro17
reviewed
Sep 17, 2020
hasbro17
reviewed
Sep 18, 2020
varshaprasad96
force-pushed
the
olm-install/bindata
branch
2 times, most recently
from
d462e12
to
9a584e7
Compare
varshaprasad96
force-pushed
the
olm-install/bindata
branch
from
9a584e7
to
5071c13
Compare
There was a problem hiding this comment.
What in IHMO shows missing to be done here:
- : add the fragment and might would be nice supplement the docs as well. Since now we will no longer fetch the internet to install the OLM if SDK has the bindata for the specific version. See: https://github.com/operator-framework/operator-sdk/pull/3906/files#r490893813
- : add a TODO comment explaining what is missing to do in the shell script to let this implementation achieve the goal if nobody has objections that it should be a follow-up [olm] Store previous versions of olm manifests #3906 (comment). I am OK with we move forward if we have what is missing properly doc in the code. 👍
estroz
reviewed
Sep 21, 2020
estroz
reviewed
Sep 21, 2020
varshaprasad96
force-pushed
the
olm-install/bindata
branch
4 times, most recently
from
7eaee58
to
d59940c
Compare
estroz
reviewed
Sep 22, 2020
estroz
reviewed
Sep 22, 2020
varshaprasad96
force-pushed
the
olm-install/bindata
branch
from
d59940c
to
b3b5b12
Compare
This PR introduces an internal optimization of not going to github and downloading the olm manifests when 'operator-sdk olm install' command is used. Previous version of olm manifest is stored as bindata and packaged along with sdk binary. When user specifies any of this version, the manifests are fetched locally and applied to the cluster.
varshaprasad96
force-pushed
the
olm-install/bindata
branch
from
b3b5b12
to
7950122
Compare
There was a problem hiding this comment.
Great work 👍 IMO before merge we need to
- address suggestion to the changelog. See: https://github.com/operator-framework/operator-sdk/pull/3906/files#r494873038
- change e2e tests to use the version 0.15.1 from the bindata. the change needs to be done in . Then we know if it is working and make the tests faster as well.
operator-sdk/test/internal/utils.go
Line 43 in 8759f01
After that, it has my /lgtm
estroz
suggested changes
Sep 25, 2020
varshaprasad96
force-pushed
the
olm-install/bindata
branch
from
7950122
to
d6c2d3e
Compare
varshaprasad96
commented
Sep 25, 2020
varshaprasad96
force-pushed
the
olm-install/bindata
branch
4 times, most recently
from
012b5a6
to
dca96e8
Compare
varshaprasad96
commented
Sep 29, 2020
estroz
suggested changes
Sep 29, 2020
varshaprasad96
force-pushed
the
olm-install/bindata
branch
2 times, most recently
from
78036ef
to
7416af5
Compare
varshaprasad96
force-pushed
the
olm-install/bindata
branch
from
7416af5
to
f06a6b2
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR introduces an internal optimization of not going to github
and downloading the olm manifests when 'operator-sdk olm install'
command is used. Previous version of olm manifest is stored as
bindata and packaged along with sdk binary. When user specifies
any of this version, the manifests are fetched locally and
applied to the cluster.
Currently, manifests for only one version of olm (0.15.1) is stored.
Motivation for the change:
Make olm subcommands more robust.
Output:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs