Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions for k8s 1.24 #5843

Merged
merged 29 commits into from Jun 10, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
23ceb3c
Bump versions for k8s 1.24
asmacdo Jun 8, 2022
0cf7b68
updates to resolve test failures
everettraven Jun 9, 2022
1cf485a
update changelog
everettraven Jun 9, 2022
668b932
update sanity go version
everettraven Jun 9, 2022
b896866
update to go 1.18
everettraven Jun 9, 2022
c86b4f7
updates for golangci-lint
everettraven Jun 9, 2022
5fcb47a
update some go1.18 lint issues
everettraven Jun 9, 2022
20b71e9
commit go.mod
everettraven Jun 9, 2022
c192f3c
update more lint problems
everettraven Jun 9, 2022
0b0083c
update java plugin
everettraven Jun 9, 2022
4c9c554
Merge branch 'master' into 2142-bump-k8s124
everettraven Jun 9, 2022
cdd2ae2
update go.mod
everettraven Jun 9, 2022
b053e48
update actions to use go 1.18
everettraven Jun 9, 2022
b7b0924
update changelog
everettraven Jun 9, 2022
3be29e0
update changelog as per review
everettraven Jun 9, 2022
3692d27
update changelog
everettraven Jun 9, 2022
2ff0f7a
update changelog
everettraven Jun 9, 2022
1974fe0
update changelog
everettraven Jun 9, 2022
4ad8f19
update changelog
everettraven Jun 9, 2022
e3cca5f
update changelog
everettraven Jun 9, 2022
d7cde37
updates to changelog per reviews
everettraven Jun 9, 2022
1ccecca
more changelog
everettraven Jun 9, 2022
b30c7a8
address nits
everettraven Jun 9, 2022
d3af0c6
update opm
everettraven Jun 10, 2022
7493c7a
update Go in docker images
everettraven Jun 10, 2022
729873c
update go in docs
everettraven Jun 10, 2022
9e71934
add newline to changelog
everettraven Jun 10, 2022
9a5fbdd
add opm detailed entries
everettraven Jun 10, 2022
c7bb4f8
fix changelog failure
everettraven Jun 10, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-go.yml
Expand Up @@ -28,7 +28,7 @@ jobs:
steps:
- uses: actions/setup-go@v2
everettraven marked this conversation as resolved.
Show resolved Hide resolved
with:
go-version: 1.17
go-version: 1.18
- uses: actions/checkout@v2
with:
fetch-depth: 0
Expand Down
34 changes: 34 additions & 0 deletions changelog/fragments/k8s-1.24-bump.yaml
@@ -0,0 +1,34 @@
# entries is a list of entries to include in
# release notes and/or the migration guide
entries:
- description: >
Bump dependencies to support Kubernetes 1.24. Projects scaffolded with the go/v3 plugin now support Go 1.18.
Dependency bumps that occurred are as follows:

github.com/operator-framework/api --> v0.15.0
everettraven marked this conversation as resolved.
Show resolved Hide resolved
github.com/operator-framework/helm-operator-plugins --> commit d3967d2ae2acf40cca1bf4215508b10a55ea6755
github.com/operator-framework/java-operator-plugins --> commit 95356a3d7a6581dba1eb3ce641b72a1f7b2e542a
github.com/operator-framework/operator-lib --> v0.11.0
github.com/operator-framework/operator-manifest-tools --> v0.2.1
github.com/operator-framework/operator-registry --> v1.23.0
helm.sh/helm/v3 --> v3.9.0
k8s.io/api --> v0.24.0
k8s.io/apiextensions-apiserver --> v0.24.0
k8s.io/apimachinery --> v0.24.0
k8s.io/cli-runtime --> v0.24.0
k8s.io/client-go --> v0.24.0
k8s.io/kubectl --> v0.24.0
sigs.k8s.io/controller-runtime --> v0.12.1
sigs.k8s.io/controller-tools --> v0.9.0
sigs.k8s.io/kubebuilder/v3 --> commit eea565cb3f508d7bcf10831d2b761dbf59af6db0
everettraven marked this conversation as resolved.
Show resolved Hide resolved

# kind is one of:
# - addition
# - change
# - deprecation
# - removal
# - bugfix
kind: "change"

# Is this a breaking change?
breaking: false
everettraven marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 0 additions & 2 deletions go.mod
Expand Up @@ -2,8 +2,6 @@ module github.com/operator-framework/operator-sdk

go 1.17

// TODO(asmacdo) kubebuilder bump
// TODO(asmacdo) operator-lib 0.11.0 release & bump
require (
github.com/blang/semver/v4 v4.0.0
github.com/fatih/structtag v1.1.0
Expand Down
2 changes: 1 addition & 1 deletion internal/ansible/flags/flag.go
Expand Up @@ -207,7 +207,7 @@ func (f *Flags) ToManagerOptions(options manager.Options) manager.Options {
options.LeaderElectionNamespace = f.LeaderElectionNamespace
}
if options.LeaderElectionResourceLock == "" {
options.LeaderElectionResourceLock = resourcelock.ConfigMapsResourceLock
options.LeaderElectionResourceLock = resourcelock.ConfigMapsLeasesResourceLock
camilamacedo86 marked this conversation as resolved.
Show resolved Hide resolved
}
if changed("graceful-shutdown-timeout") || options.GracefulShutdownTimeout == nil {
options.GracefulShutdownTimeout = &f.GracefulShutdownTimeout
Expand Down
2 changes: 1 addition & 1 deletion internal/helm/flags/flag.go
Expand Up @@ -151,7 +151,7 @@ func (f *Flags) ToManagerOptions(options manager.Options) manager.Options {
options.LeaderElectionNamespace = f.LeaderElectionNamespace
}
if options.LeaderElectionResourceLock == "" {
options.LeaderElectionResourceLock = resourcelock.ConfigMapsResourceLock
options.LeaderElectionResourceLock = resourcelock.ConfigMapsLeasesResourceLock
camilamacedo86 marked this conversation as resolved.
Show resolved Hide resolved
}

return options
Expand Down
Expand Up @@ -349,7 +349,7 @@ func generateRoleRules(dc roleDiscoveryInterface, chart *chart.Chart) ([]rbacv1.
func getDefaultManifests(c *chart.Chart) ([]releaseutil.Manifest, error) {
install := action.NewInstall(&action.Configuration{})
install.DryRun = true
install.ReleaseName = "RELEASE-NAME"
install.ReleaseName = "release-name"
install.Replace = true
install.ClientOnly = true
rel, err := install.Run(c, nil)
Expand Down
2 changes: 1 addition & 1 deletion testdata/go/v3/memcached-operator/Dockerfile
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.17 as builder
FROM golang:1.18 as builder

WORKDIR /workspace
# Copy the Go Modules manifests
Expand Down
4 changes: 2 additions & 2 deletions testdata/go/v3/memcached-operator/Makefile
Expand Up @@ -49,7 +49,7 @@ endif
# Image URL to use all building/pushing image targets
IMG ?= controller:latest
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.23
ENVTEST_K8S_VERSION = 1.24.1

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
Expand Down Expand Up @@ -161,7 +161,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest

## Tool Versions
KUSTOMIZE_VERSION ?= v3.8.7
CONTROLLER_TOOLS_VERSION ?= v0.8.0
CONTROLLER_TOOLS_VERSION ?= v0.9.0

KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"
.PHONY: kustomize
Expand Down
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
controller-gen.kubebuilder.io/version: v0.9.0
creationTimestamp: null
name: memcacheds.cache.example.com
spec:
Expand Down Expand Up @@ -62,5 +62,5 @@ status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
conditions: null
storedVersions: null
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
controller-gen.kubebuilder.io/version: v0.9.0
creationTimestamp: null
name: memcacheds.cache.example.com
spec:
Expand Down Expand Up @@ -59,9 +59,3 @@ spec:
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Expand Up @@ -55,7 +55,7 @@ type MemcachedReconciler struct {
// the user.
//
// For more details, check Reconcile and its Result here:
// - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.11.2/pkg/reconcile
// - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.12.1/pkg/reconcile
func (r *MemcachedReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
log := ctrllog.FromContext(ctx)

Expand Down
55 changes: 32 additions & 23 deletions testdata/go/v3/memcached-operator/go.mod
@@ -1,14 +1,14 @@
module github.com/example/memcached-operator

go 1.17
go 1.18

require (
github.com/onsi/ginkgo v1.16.5
github.com/onsi/gomega v1.17.0
k8s.io/api v0.23.5
k8s.io/apimachinery v0.23.5
k8s.io/client-go v0.23.5
sigs.k8s.io/controller-runtime v0.11.2
github.com/onsi/gomega v1.18.1
k8s.io/api v0.24.0
k8s.io/apimachinery v0.24.0
k8s.io/client-go v0.24.0
sigs.k8s.io/controller-runtime v0.12.1
)

require (
Expand All @@ -19,56 +19,65 @@ require (
github.com/Azure/go-autorest/autorest/date v0.3.0 // indirect
github.com/Azure/go-autorest/logger v0.2.1 // indirect
github.com/Azure/go-autorest/tracing v0.6.0 // indirect
github.com/PuerkitoBio/purell v1.1.1 // indirect
github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/cespare/xxhash/v2 v2.1.1 // indirect
github.com/cespare/xxhash/v2 v2.1.2 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/emicklei/go-restful v2.9.5+incompatible // indirect
github.com/evanphx/json-patch v4.12.0+incompatible // indirect
github.com/form3tech-oss/jwt-go v3.2.3+incompatible // indirect
github.com/fsnotify/fsnotify v1.5.1 // indirect
github.com/go-logr/logr v1.2.0 // indirect
github.com/go-logr/zapr v1.2.0 // indirect
github.com/go-openapi/jsonpointer v0.19.5 // indirect
github.com/go-openapi/jsonreference v0.19.5 // indirect
github.com/go-openapi/swag v0.19.14 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/google/gnostic v0.5.7-v3refs // indirect
github.com/google/go-cmp v0.5.5 // indirect
github.com/google/gofuzz v1.1.0 // indirect
github.com/google/uuid v1.1.2 // indirect
github.com/googleapis/gnostic v0.5.5 // indirect
github.com/imdario/mergo v0.3.12 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/mailru/easyjson v0.7.6 // indirect
github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/nxadm/tail v1.4.8 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/prometheus/client_golang v1.11.0 // indirect
github.com/prometheus/client_golang v1.12.1 // indirect
github.com/prometheus/client_model v0.2.0 // indirect
github.com/prometheus/common v0.28.0 // indirect
github.com/prometheus/procfs v0.6.0 // indirect
github.com/prometheus/common v0.32.1 // indirect
github.com/prometheus/procfs v0.7.3 // indirect
github.com/spf13/pflag v1.0.5 // indirect
go.uber.org/atomic v1.7.0 // indirect
go.uber.org/multierr v1.6.0 // indirect
go.uber.org/zap v1.19.1 // indirect
golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 // indirect
golang.org/x/net v0.0.0-20211209124913-491a49abca63 // indirect
golang.org/x/oauth2 v0.0.0-20210819190943-2bc19b11175f // indirect
golang.org/x/sys v0.0.0-20211029165221-6e7872819dc8 // indirect
golang.org/x/term v0.0.0-20210615171337-6886f2dfbf5b // indirect
golang.org/x/crypto v0.0.0-20220214200702-86341886e292 // indirect
golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd // indirect
golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8 // indirect
golang.org/x/sys v0.0.0-20220209214540-3681064d5158 // indirect
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect
golang.org/x/text v0.3.7 // indirect
golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac // indirect
golang.org/x/time v0.0.0-20220210224613-90d013bbcef8 // indirect
gomodules.xyz/jsonpatch/v2 v2.2.0 // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/protobuf v1.27.1 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
k8s.io/apiextensions-apiserver v0.23.5 // indirect
k8s.io/component-base v0.23.5 // indirect
k8s.io/klog/v2 v2.30.0 // indirect
k8s.io/kube-openapi v0.0.0-20211115234752-e816edb12b65 // indirect
k8s.io/utils v0.0.0-20211116205334-6203023598ed // indirect
sigs.k8s.io/json v0.0.0-20211020170558-c049b76a60c6 // indirect
k8s.io/apiextensions-apiserver v0.24.0 // indirect
k8s.io/component-base v0.24.0 // indirect
k8s.io/klog/v2 v2.60.1 // indirect
k8s.io/kube-openapi v0.0.0-20220328201542-3ee0da9b0b42 // indirect
k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9 // indirect
sigs.k8s.io/json v0.0.0-20211208200746-9f7c6b3444d2 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect
sigs.k8s.io/yaml v1.3.0 // indirect
)