Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-52034] Update IGV to netbeans 20 and JDK 21 #8359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

graalvmbot
Copy link
Collaborator

Update the base of IGV to netbeans 20 and support JDK11 through JDK21.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 12, 2024
org.netbeans.modules.lsp.client,\
org.netbeans.modules.markdown,\
org.netbeans.modules.maven.checkstyle,\
org.netbeans.modules.maven.coverage,\
org.netbeans.modules.maven.grammar,\
org.netbeans.modules.maven.graph,\
org.netbeans.modules.maven.htmlui,\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you enabling this module?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which module do you mean? I got complaints in the libraries panel and tried to make them go away. I would have sworn I disabled all the gradle stuff not enabled more. I take a look. I don't think it's related to the problem I'm having though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my brain just caught up with the fact that this is an exclusion list so - means adding. I didn't explicitly add org.netbeans.modules.maven.htmlui so it must have been auto enabled. I'll do another pass over this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run the tests and yes, there is a problem with net.java.html & co. dependencies. I've never seen it myself. I don't know what is wrong off-hand. Debugging is needed - I'd ask some NetBeans experts like Sváťa for help.

@tkrodriguez
Copy link
Member

I can make that problem go away by duplicating the import of net.java.html in the project.xml, which is bizarre.
It normally fails

$ mx unittest |& grep net.java.html
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html.json was needed and not found.
    [junit] 	Settings - The module named net.java.html was needed and not found.
    [junit] 	Settings - The module named net.java.html.json was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html.json was needed and not found.
    [junit] 	Settings - The module named net.java.html was needed and not found.
    [junit] 	Settings - The module named net.java.html.json was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html.json was needed and not found.
    [junit] 	Settings - The module named net.java.html was needed and not found.
    [junit] 	Settings - The module named net.java.html.json was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html.json was needed and not found.
    [junit] 	Settings - The module named net.java.html was needed and not found.
    [junit] 	Settings - The module named net.java.html.json was needed and not found.

adding a duplicate of the first entry

$ git diff
diff --git a/visualizer/IdealGraphVisualizer/Settings/nbproject/project.xml b/visualizer/IdealGraphVisualizer/Settings/nbproject/project.xml
index eeae021df47..f836b2dab0d 100644
--- a/visualizer/IdealGraphVisualizer/Settings/nbproject/project.xml
+++ b/visualizer/IdealGraphVisualizer/Settings/nbproject/project.xml
@@ -6,6 +6,14 @@
             <code-name-base>org.graalvm.visualizer.settings</code-name-base>
             <suite-component/>
             <module-dependencies>
+                <dependency>
+                    <code-name-base>net.java.html</code-name-base>
+                    <build-prerequisite/>
+                    <compile-dependency/>
+                    <run-dependency>
+                        <specification-version>1.8.1</specification-version>
+                    </run-dependency>
+                </dependency>
                 <dependency>
                     <code-name-base>net.java.html</code-name-base>
                     <build-prerequisite/>

then causes it to successfully load those modules. It fails for other unrelated reasons. Obviously something weird is going on. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants