New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-52034] Update IGV to netbeans 20 and JDK 21 #8359
base: master
Are you sure you want to change the base?
Conversation
org.netbeans.modules.lsp.client,\ | ||
org.netbeans.modules.markdown,\ | ||
org.netbeans.modules.maven.checkstyle,\ | ||
org.netbeans.modules.maven.coverage,\ | ||
org.netbeans.modules.maven.grammar,\ | ||
org.netbeans.modules.maven.graph,\ | ||
org.netbeans.modules.maven.htmlui,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you enabling this module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which module do you mean? I got complaints in the libraries panel and tried to make them go away. I would have sworn I disabled all the gradle stuff not enabled more. I take a look. I don't think it's related to the problem I'm having though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my brain just caught up with the fact that this is an exclusion list so -
means adding. I didn't explicitly add org.netbeans.modules.maven.htmlui so it must have been auto enabled. I'll do another pass over this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run the tests and yes, there is a problem with net.java.html
& co. dependencies. I've never seen it myself. I don't know what is wrong off-hand. Debugging is needed - I'd ask some NetBeans experts like Sváťa for help.
I can make that problem go away by duplicating the import of net.java.html in the project.xml, which is bizarre.
adding a duplicate of the first entry
then causes it to successfully load those modules. It fails for other unrelated reasons. Obviously something weird is going on. Any suggestions? |
Update the base of IGV to netbeans 20 and support JDK11 through JDK21.