-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-52034] Update IGV to netbeans 20 and JDK 21 #8359
Open
graalvmbot
wants to merge
1
commit into
master
Choose a base branch
from
tkr-igv-update
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
visualizer/IdealGraphVisualizer/BatikSVGProxy/nbproject/project.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
javac.source=1.7 | ||
javac.source=1.8 | ||
javac.compilerargs=-Xlint -Xlint:-serial |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
visualizer/IdealGraphVisualizer/Layout/nbproject/project.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
javac.source=1.7 | ||
javac.source=1.8 | ||
javac.compilerargs=-Xlint -Xlint:-serial |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
visualizer/IdealGraphVisualizer/SettingsUI/nbproject/genfiles.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
build.xml.data.CRC32=bdb96219 | ||
build.xml.data.CRC32=45e818a7 | ||
build.xml.script.CRC32=8a12d486 | ||
build.xml.stylesheet.CRC32=15ca8a54@2.74.1 | ||
build.xml.stylesheet.CRC32=15ca8a54@2.94 | ||
# This file is used by a NetBeans-based IDE to track changes in generated files such as build-impl.xml. | ||
# Do not edit this file. You may delete it but then the IDE will never regenerate such files for you. | ||
nbproject/build-impl.xml.data.CRC32=bdb96219 | ||
nbproject/build-impl.xml.data.CRC32=45e818a7 | ||
nbproject/build-impl.xml.script.CRC32=bac885a3 | ||
nbproject/build-impl.xml.stylesheet.CRC32=49aa68b0@2.74.1 | ||
nbproject/build-impl.xml.stylesheet.CRC32=49aa68b0@2.94 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
visualizer/IdealGraphVisualizer/VisualizerUI/nbproject/project.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
is.eager=true | ||
javac.source=1.7 | ||
javac.source=1.8 | ||
javac.compilerargs=-Xlint -Xlint:-serial |
6 changes: 3 additions & 3 deletions
6
visualizer/IdealGraphVisualizer/VisualizerUI/src/org/graalvm/visualizer/ui/Bundle.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
OpenIDE-Module-Name=Visualizer UI Customizations | ||
OpenIDE-Module-Display-Category=IGV | ||
Services/AutoupdateType/distribution-update-provider.instance=NetBeans 12.5 distribution | ||
URL_NBUpdateCenter=https://netbeans.apache.org/nb/updates/12.5/updates.xml.gz?{$netbeans.hash.code} | ||
URL_NBPluginPortal=https://netbeans.apache.org/nb/plugins/12.5/catalog.xml.gz | ||
Services/AutoupdateType/distribution-update-provider.instance=NetBeans 20.0 distribution | ||
URL_NBUpdateCenter=https://netbeans.apache.org/nb/updates/20/updates.xml.gz?{$netbeans.hash.code} | ||
URL_NBPluginPortal=https://netbeans.apache.org/nb/plugins/20/catalog.xml.gz |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you enabling this module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which module do you mean? I got complaints in the libraries panel and tried to make them go away. I would have sworn I disabled all the gradle stuff not enabled more. I take a look. I don't think it's related to the problem I'm having though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my brain just caught up with the fact that this is an exclusion list so
-
means adding. I didn't explicitly add org.netbeans.modules.maven.htmlui so it must have been auto enabled. I'll do another pass over this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run the tests and yes, there is a problem with
net.java.html
& co. dependencies. I've never seen it myself. I don't know what is wrong off-hand. Debugging is needed - I'd ask some NetBeans experts like Sváťa for help.