Blueprints: Fix snapshots + latest release #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
approved these changes
May 6, 2024
regexowl
force-pushed
the
blueprint-with-latest-release-version
branch
from
f705ac7
to
0a51537
Compare
|
/retest |
croissanne
previously approved these changes
May 6, 2024
lucasgarfield
force-pushed
the
blueprint-with-latest-release-version
branch
from
0a51537
to
b9c617b
Compare
|
This might be a bit confusing a year from now when we forget about why we needed this. Would extracting it to a well named function with an explanatory comment help future us? |
regexowl
force-pushed
the
blueprint-with-latest-release-version
branch
from
b9c617b
to
59d0b19
Compare
|
/retest |
regexowl
force-pushed
the
blueprint-with-latest-release-version
branch
from
59d0b19
to
19e1e2f
Compare
|
/retest |
Previously created blueprints didn't take into account what the current latest RHEL release is and built the specific minor release that was included in the blueprint. This should fix the bug and also fix snapshots.
regexowl
force-pushed
the
blueprint-with-latest-release-version
branch
from
19e1e2f
to
7cd3e8b
Compare
|
#2060 is merged so I've updated the comments to reflect the currently used major version. This PR is ready for review again. |
|
@croissanne could you merge this one? :) |
croissanne
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously created blueprints didn't take into account what the current latest RHEL release is and built the specific minor release that was included in the blueprint. This should fix the bug and also fix snapshots.