Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/constants: Use major rhel distros by default #2060

Merged
merged 1 commit into from
May 21, 2024

Conversation

croissanne
Copy link
Member

The tradeoff is not being able to discern between a minor version and a major version in the 2 weeks post GA if the images were built using the UI, but I think the tradeoff is worth it. The frontend will never need updating to switch to a new version.

@regexowl
Copy link
Collaborator

regexowl commented May 6, 2024

I wouldn't mind dropping the detail of minor version, we don't let the user choose between those anyway. And I like the idea of not having to update them after release.

Should we add some kind of information about "image builder building always the latest and greatest" somewhere though?

If we don't specify minor version would the images automatically be built with the latest version? There are still out of date blueprints which I guess could be handled via a change to request mapper, but that would work only for editing blueprints. If I just click on "Build image" for rhel-93 blueprint, what version would it pick for a build?

Copy link
Collaborator

@regexowl regexowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

There are still out of date blueprints which I guess could be handled via a change to request mapper

is covered in #2058

If I just click on "Build image" for rhel-93 blueprint, what version would it pick for a build?

opened an issue for this one #2071

@croissanne
Copy link
Member Author

/retest

1 similar comment
@ezr-ondrej
Copy link
Contributor

/retest

@regexowl
Copy link
Collaborator

/retest

@regexowl
Copy link
Collaborator

DO NOT MERGE! Needs to pass pr_check which is currently broken.

@ezr-ondrej
Copy link
Contributor

/retest

2 similar comments
@ezr-ondrej
Copy link
Contributor

/retest

@ezr-ondrej
Copy link
Contributor

/retest

The tradeoff is not being able to discern between a minor version and a
major version in the 2 weeks post GA if the images were built using the
UI, but I think the tradeoff is worth it. The frontend will never need
updating to switch to a new version.
@regexowl
Copy link
Collaborator

pr_check passed! Let's rebase, make it pass again and then we can merge :)

@regexowl regexowl merged commit 967b603 into osbuild:main May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants