-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/constants: Use major rhel distros by default #2060
Conversation
c1fa6e9
to
e0efdfa
Compare
I wouldn't mind dropping the detail of minor version, we don't let the user choose between those anyway. And I like the idea of not having to update them after release. Should we add some kind of information about "image builder building always the latest and greatest" somewhere though? If we don't specify minor version would the images automatically be built with the latest version? There are still out of date blueprints which I guess could be handled via a change to request mapper, but that would work only for editing blueprints. If I just click on "Build image" for rhel-93 blueprint, what version would it pick for a build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e0efdfa
to
bae8264
Compare
/retest |
1 similar comment
/retest |
bae8264
to
4d7fe52
Compare
/retest |
DO NOT MERGE! Needs to pass pr_check which is currently broken. |
/retest |
2 similar comments
/retest |
/retest |
The tradeoff is not being able to discern between a minor version and a major version in the 2 weeks post GA if the images were built using the UI, but I think the tradeoff is worth it. The frontend will never need updating to switch to a new version.
4d7fe52
to
de8c78e
Compare
pr_check passed! Let's rebase, make it pass again and then we can merge :) |
The tradeoff is not being able to discern between a minor version and a major version in the 2 weeks post GA if the images were built using the UI, but I think the tradeoff is worth it. The frontend will never need updating to switch to a new version.