feat(linter/import) implement no_unused_modules rule

[Dunqing]

No description provided.

[Dunqing]

• feat(linter/import) implement no_unused_modules rule #2720 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #2720 will improve performances by 3.68%

_{Comparing 03-14-feat_linter/import_implement_no_unused_modules_rule (e89af90) with main (53a8e7f)}

Summary

⚡ 1 improvements
✅ 28 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	03-14-feat_linter/import_implement_no_unused_modules_rule	Change
⚡	codegen_sourcemap[react.development.js]	16 ms	15.4 ms	+3.68%

[Dunqing]

Supporting unused_exports looks cumbersome, we need to check all files in the src option and check them individually for imports.

[Boshen]

Supporting unused_exports looks cumbersome, we need to check all files in the src option and check them individually for imports.

I'm fine with that.

[Dunqing]

I'm fine with that.

Can we retrieve and save all the src files in the linter service in advance so that we don't have to repeat the query every time we run run_once?

[Boshen]

I'm fine with that.

Can we retrieve and save all the src files in the linter service in advance so that we don't have to repeat the query every time we run run_once?

Can you give an example? I haven't looked at what this rule does yet.

[Dunqing]

I'm fine with that.

Can we retrieve and save all the src files in the linter service in advance so that we don't have to repeat the query every time we run run_once?

Can you give an example? I haven't looked at what this rule does yet.

You can see https://github.com/import-js/eslint-plugin-import/blob/c77c1a6ace311f99ed25878768c2dbee49c0512a/docs/rules/no-unused-modules.md#example-for-unused-exports

[Dunqing]

Support for the unused_exports option is not considered for the time being