Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter/import) change the rule path to index.ts and add snapshot in export rule #2732

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 15, 2024

Looks like the current implementation is incorrect

Copy link
Member Author

Dunqing commented Mar 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Mar 15, 2024
@Dunqing Dunqing force-pushed the 03-15-feat_linter/import_change_the_rule_path_to_index.ts_and_add_snapshot_in_export_rule branch from d066b24 to 3d27756 Compare March 15, 2024 12:56
@Dunqing Dunqing changed the base branch from 03-14-feat_linter/import_implement_no_unused_modules_rule to main March 15, 2024 12:56
Copy link

codspeed-hq bot commented Mar 15, 2024

CodSpeed Performance Report

Merging #2732 will not alter performance

Comparing 03-15-feat_linter/import_change_the_rule_path_to_index.ts_and_add_snapshot_in_export_rule (650ff82) with main (ac813a6)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 03-15-feat_linter/import_change_the_rule_path_to_index.ts_and_add_snapshot_in_export_rule branch from 3d27756 to 650ff82 Compare March 19, 2024 14:13
@Boshen Boshen merged commit 99dcd00 into main Mar 19, 2024
34 checks passed
@Boshen Boshen deleted the 03-15-feat_linter/import_change_the_rule_path_to_index.ts_and_add_snapshot_in_export_rule branch March 19, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants