Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic): ModuleRecord's indirect_export_entires missing reexported imports #2792

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 23, 2024

local_name has name and span. We can't directly compare ExportEntry's local_name and ImportEntry's local_name. because the span is never equal.

@github-actions github-actions bot added the A-semantic Area - Semantic label Mar 23, 2024
Copy link
Member Author

Dunqing commented Mar 23, 2024

Copy link

codspeed-hq bot commented Mar 23, 2024

CodSpeed Performance Report

Merging #2792 will improve performances by 13.63%

Comparing 03-23-fix_semantic_ModuleRecord_s_indirect_export_entires_missing_reexported_imports (93e7b42) with main (4a42c5f)

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

Benchmark main 03-23-fix_semantic_ModuleRecord_s_indirect_export_entires_missing_reexported_imports Change
semantic[cal.com.tsx] 257.9 ms 226.9 ms +13.63%

@Dunqing Dunqing force-pushed the 03-23-fix_semantic_ModuleRecord_s_indirect_export_entires_missing_reexported_imports branch 2 times, most recently from 274df4b to 5e6292c Compare March 23, 2024 11:31
@Dunqing Dunqing force-pushed the 03-23-fix_semantic_ModuleRecord_s_indirect_export_entires_missing_reexported_imports branch from 5e6292c to 93e7b42 Compare March 23, 2024 11:41
@Boshen
Copy link
Member

Boshen commented Mar 23, 2024

Can you double check with the spec? I want to make sure that we are on the same page.

https://tc39.es/ecma262/#sec-parsemodule step 10

@Dunqing
Copy link
Member Author

Dunqing commented Mar 23, 2024

Can you double check with the spec? I want to make sure that we are on the same page.

https://tc39.es/ecma262/#sec-parsemodule step 10

I have been checked, comments and behaviour consistent with the spec

@Boshen Boshen merged commit b6e493b into main Mar 24, 2024
32 checks passed
@Boshen Boshen deleted the 03-23-fix_semantic_ModuleRecord_s_indirect_export_entires_missing_reexported_imports branch March 24, 2024 20:50
charnog pushed a commit to charnog/oxc that referenced this pull request Mar 26, 2024
…ted imports (oxc-project#2792)

local_name has `name` and `span`. We can't directly compare
ExportEntry's local_name and ImportEntry's local_name. because the span
is never equal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants