fix(semantic): incorrect ExportEntry span for ExportAllDeclaration in ModuleRecord #2793
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #2793 will improve performances by 4.39%Comparing Summary
Benchmarks breakdown
|
Base automatically changed from
03-23-fix_semantic_ModuleRecord_s_indirect_export_entires_missing_reexported_imports
to
main
March 24, 2024 20:50
Dunqing
force-pushed
the
03-23-fix_semantic_incorrect_ExportEntry_span_for_ExportAllDeclaration_in_ModuleRecord
branch
from
3a2607a
to
94e22e8
Compare
Dunqing
force-pushed
the
03-23-fix_semantic_incorrect_ExportEntry_span_for_ExportAllDeclaration_in_ModuleRecord
branch
from
94e22e8
to
e94b7ce
Compare
Boshen
deleted the
03-23-fix_semantic_incorrect_ExportEntry_span_for_ExportAllDeclaration_in_ModuleRecord
branch
charnog
pushed a commit
to charnog/oxc
that referenced
this pull request
Mar 26, 2024
… ModuleRecord (oxc-project#2793) Now the span is ExportAllDeclaration's span
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the span is ExportAllDeclaration's span