Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(transformer): pass options via context. #2794

Merged
merged 4 commits into from Mar 26, 2024
Merged

refactor(transformer): pass options via context. #2794

merged 4 commits into from Mar 26, 2024

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Mar 23, 2024

With this PR all transformers would get their AstBuilder and options via TransformerCtx.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 23, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 23, 2024 •
edited

CodSpeed Performance Report

Merging #2794 will not alter performance

Comparing rzvxa:trans-ctx (5604329) with main (243131d)

Summary

✅ 34 untouched benchmarks

@rzvxa rzvxa mentioned this pull request Mar 24, 2024
Merged
Dunqing
Dunqing approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes.

@Dunqing Dunqing requested a review from Boshen March 26, 2024 11:01
@Boshen Boshen merged commit fe12617 into oxc-project:main Mar 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Dunqing approved these changes

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rzvxa @Dunqing @Boshen