Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update babel version #2814

Merged
merged 1 commit into from Mar 26, 2024
Merged

ci: update babel version #2814

merged 1 commit into from Mar 26, 2024

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Mar 26, 2024

In my privius PR I changed this version in justfile It seems like the version used in CI is different from justfile.

@rzvxa
Copy link
Collaborator Author

rzvxa commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa marked this pull request as ready for review March 26, 2024 02:09
@rzvxa rzvxa requested a review from Dunqing March 26, 2024 02:09
@Dunqing Dunqing merged commit dcbbda3 into main Mar 26, 2024
4 checks passed
@Dunqing Dunqing deleted the 03-26-ci_update_babel_version branch March 26, 2024 02:13
@rzvxa
Copy link
Collaborator Author

rzvxa commented Mar 26, 2024

@Dunqing It changes snapshots that were not included in this PR, My bad! It will break the CI I'm running the task to update it but since I haven't cloned submodules it would take a while to run from a cold start, Sorry for the inconvenience. Since it might take a while to run the tests feel free to push the updated snapshots yourself, Don't wait for my PR. If I see it fixed I will close my PR.

@Dunqing
Copy link
Member

Dunqing commented Mar 26, 2024

@Dunqing It changes snapshots that were not included in this PR, My bad! It will break the CI I'm running the task to update it but since I haven't cloned submodules it would take a while to run from a cold start, Sorry for the inconvenience. Since it might take a while to run the tests feel free to push the updated snapshots yourself, Don't wait for my PR. If I see it fixed I will close my PR.

Don't worry. I think we should make sure ci runs when clone-submodules/action.yml changes. I made a fix in #2816

@Dunqing Dunqing mentioned this pull request Mar 26, 2024
@rzvxa
Copy link
Collaborator Author

rzvxa commented Mar 26, 2024

Don't worry. I think we should make sure ci runs when clone-submodules/action.yml changes. I made a fix in #2816

Thanks, It is a good idea.
I found the issue on why the conformance doesn't run on my local machine, But I'm relieved to see that you already addressed it.

Dunqing added a commit that referenced this pull request Mar 26, 2024
Babel repo is updated in #2813 and #2814
charnog pushed a commit to charnog/oxc that referenced this pull request Mar 26, 2024
In my privius PR I changed this version in justfile It seems like the
version used in CI is different from justfile.
charnog pushed a commit to charnog/oxc that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants