Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter/import): change all recommend rules category #2841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 28, 2024

Correctness

  • named
  • export
  • default
  • namespace
  • no-unresolved

The above rules will prevent bugs or broken, so I changed these to correctness

Suspicious

  • no-duplicates
  • no-named-as-default-member
  • no-named-as-default

I'm still not sure whether the no-unresolved rule should be changed to correctness. Because I found that the rule reported a lot in the AFFiNE. But in fact, they are all correct reports

Copy link
Member Author

Dunqing commented Mar 28, 2024

@Dunqing Dunqing marked this pull request as draft March 28, 2024 04:10
@Boshen Boshen force-pushed the 03-28-feat_linter/import_support_allow_computed_option_in_namespace branch from 2d9f0b9 to c7e9310 Compare March 28, 2024 06:47
Base automatically changed from 03-28-feat_linter/import_support_allow_computed_option_in_namespace to main March 28, 2024 06:49
@Dunqing Dunqing force-pushed the 03-28-feat_linter/import_change_all_recommend_rules_category_to_suspicious branch 2 times, most recently from 7524694 to b45e4fb Compare March 30, 2024 04:07
@Dunqing Dunqing changed the title feat(linter/import): change all recommend rules category to suspicious feat(linter/import): change all recommend rules category Mar 30, 2024
Copy link

codspeed-hq bot commented Mar 30, 2024

CodSpeed Performance Report

Merging #2841 will not alter performance

Comparing 03-28-feat_linter/import_change_all_recommend_rules_category_to_suspicious (503ba15) with main (2365198)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing force-pushed the 03-28-feat_linter/import_change_all_recommend_rules_category_to_suspicious branch from b45e4fb to 503ba15 Compare March 30, 2024 04:16
@Dunqing Dunqing requested a review from Boshen March 30, 2024 04:20
@Dunqing Dunqing marked this pull request as ready for review March 30, 2024 04:21
@Boshen
Copy link
Member

Boshen commented Mar 30, 2024

Let me do a new release before merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants