Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter/import): move some rules out of nursery #2841

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules.rs
Expand Up @@ -14,7 +14,7 @@ mod import {
pub mod no_amd;
pub mod no_cycle;
pub mod no_default_export;
pub mod no_deprecated;
// pub mod no_deprecated;
pub mod no_duplicates;
pub mod no_named_as_default;
pub mod no_named_as_default_member;
Expand Down Expand Up @@ -643,7 +643,7 @@ oxc_macros::declare_all_lint_rules! {
import::namespace,
import::no_amd,
import::no_cycle,
import::no_deprecated,
// import::no_deprecated,
import::no_named_as_default,
import::no_named_as_default_member,
import::no_self_import,
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/import/default.rs
Expand Up @@ -32,7 +32,7 @@ declare_oxc_lint!(
/// import bar from './bar' // no default export found in ./bar
/// ```
Default,
nursery
correctness
);

impl Rule for Default {
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/import/named.rs
Expand Up @@ -26,7 +26,7 @@ declare_oxc_lint!(
/// ```javascript
/// ```
Named,
nursery
correctness
);

impl Rule for Named {
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/import/namespace.rs
Expand Up @@ -47,7 +47,7 @@ declare_oxc_lint!(
/// Also, will report for computed references (i.e. foo["bar"]()).
/// Reports on assignment to a member of an imported namespace.
Namespace,
nursery
correctness
);

impl Rule for Namespace {
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/import/no_duplicates.rs
Expand Up @@ -16,7 +16,7 @@ declare_oxc_lint!(
///
/// Reports if a resolved path is imported more than once.
NoDuplicates,
nursery
suspicious
);

impl Rule for NoDuplicates {
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/import/no_named_as_default.rs
Expand Up @@ -39,7 +39,7 @@ declare_oxc_lint!(
/// import bar from './foo.js';
/// ```
NoNamedAsDefault,
nursery
suspicious
);

impl Rule for NoNamedAsDefault {
Expand Down
Expand Up @@ -43,7 +43,7 @@ declare_oxc_lint!(
/// const bar = foo.bar // trying to access named export via default
/// ```
NoNamedAsDefaultMember,
nursery
suspicious
);
fn get_symbol_id_from_ident(
ctx: &LintContext<'_>,
Expand Down