New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: display current ASN in statistics #6692
Conversation
Hello @darmiel, Thank you very much for submitting this PR to us! This is what will happen next:
You'll be hearing from us soon, and thank you again for contributing to our project. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6692 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 436 436
Lines 17968 17969 +1
Branches 1522 1519 -3
=======================================
+ Hits 17464 17465 +1
- Misses 501 504 +3
+ Partials 3 0 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c043e2d
to
9429229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Im good with the change in general, but I think it'd be cleaner to just add the asn output to the statistics response, rather than making a separate http call. Its obviously not going a significant performance difference, but still makes more sense i think.
Also this will need an update to the translation strings
9429229
to
83fd2dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, think it just needs a re-base on dev
Head branch was pushed to by a user without write access
83fd2dd
to
3979629
Compare
…gx to v2.8.4@25909b5 by renovate (#22005) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/paperless-ngx/paperless-ngx](https://togithub.com/paperless-ngx/paperless-ngx) | patch | `2.8.3` -> `2.8.4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>paperless-ngx/paperless-ngx (ghcr.io/paperless-ngx/paperless-ngx)</summary> ### [`v2.8.4`](https://togithub.com/paperless-ngx/paperless-ngx/releases/tag/v2.8.4): Paperless-ngx v2.8.4 [Compare Source](https://togithub.com/paperless-ngx/paperless-ngx/compare/v2.8.3...v2.8.4) #### paperless-ngx 2.8.4 ##### Features - Enhancement: display current ASN in statistics [@​darmiel](https://togithub.com/darmiel) ([paperless-ngx/paperless-ngx#6692) - Enhancement: global search tweaks [@​shamoon](https://togithub.com/shamoon) ([#​6674](https://togithub.com/paperless-ngx/paperless-ngx/pull/6674)) ##### Bug Fixes - Security: Correctly disable `eval` in pdfjs [@​shamoon](https://togithub.com/shamoon) ([#​6702](https://togithub.com/paperless-ngx/paperless-ngx/pull/6702)) - Fix: history timestamp tooltip illegible in dark mode [@​shamoon](https://togithub.com/shamoon) ([#​6696](https://togithub.com/paperless-ngx/paperless-ngx/pull/6696)) - Fix: only count inbox documents from inbox tags with permissions [@​shamoon](https://togithub.com/shamoon) ([#​6670](https://togithub.com/paperless-ngx/paperless-ngx/pull/6670)) ##### All App Changes <details> <summary>5 changes</summary> - Enhancement: global search tweaks [@​shamoon](https://togithub.com/shamoon) ([#​6674](https://togithub.com/paperless-ngx/paperless-ngx/pull/6674)) - Security: Correctly disable `eval` in pdfjs [@​shamoon](https://togithub.com/shamoon) ([#​6702](https://togithub.com/paperless-ngx/paperless-ngx/pull/6702)) - Fix: history timestamp tooltip illegible in dark mode [@​shamoon](https://togithub.com/shamoon) ([#​6696](https://togithub.com/paperless-ngx/paperless-ngx/pull/6696)) - Enhancement: display current ASN in statistics [@​darmiel](https://togithub.com/darmiel) ([#​6692](https://togithub.com/paperless-ngx/paperless-ngx/pull/6692)) - Fix: only count inbox documents from inbox tags with permissions [@​shamoon](https://togithub.com/shamoon) ([#​6670](https://togithub.com/paperless-ngx/paperless-ngx/pull/6670)) </details> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTguMCIsInVwZGF0ZWRJblZlciI6IjM3LjM1OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Proposed change
This pull request adds the current ASN to the dashboard.:
If no ASN has been assigned yet, the number is hidden.
Closes #430
Type of change
Checklist:
backendand / or front-end changes.pre-commit
hooks, see documentation.