Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: display current ASN in statistics #6692

Merged
merged 2 commits into from May 12, 2024

Conversation

darmiel
Copy link
Contributor

@darmiel darmiel commented May 12, 2024

Proposed change

This pull request adds the current ASN to the dashboard.:

image

If no ASN has been assigned yet, the number is hidden.

Closes #430

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@darmiel darmiel requested a review from a team as a code owner May 12, 2024 14:55
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels May 12, 2024
@paperless-ngx-secretary
Copy link

Hello @darmiel,

Thank you very much for submitting this PR to us!

This is what will happen next:

  1. Once enabled by a maintainer, our ci tests will run against your PR to ensure quality and consistency.
  2. Next, human contributors from paperless-ngx review your changes. Since this is a non-trivial change, a review from at least two contributors is required.
  3. Please address any issues that come up during the review as soon as you are able to.
  4. If accepted, your pull request will be merged into the dev branch and changes there will be tested further.
  5. Eventually, changes from you and other contributors will be merged into main and a new release will be made.

You'll be hearing from us soon, and thank you again for contributing to our project.

@darmiel darmiel changed the title Feat/dashboard asn stat feat[dashboard]: display current ASN in statistics May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (6fa3522) to head (3979629).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6692   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         436      436           
  Lines       17968    17969    +1     
  Branches     1522     1519    -3     
=======================================
+ Hits        17464    17465    +1     
- Misses        501      504    +3     
+ Partials        3        0    -3     
Flag Coverage Δ
backend 95.88% <100.00%> (+<0.01%) ⬆️
frontend 98.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon changed the title feat[dashboard]: display current ASN in statistics Enhancement: display current ASN in statistics May 12, 2024
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Im good with the change in general, but I think it'd be cleaner to just add the asn output to the statistics response, rather than making a separate http call. Its obviously not going a significant performance difference, but still makes more sense i think.

Also this will need an update to the translation strings

@darmiel darmiel requested a review from a team as a code owner May 12, 2024 18:22
@darmiel darmiel requested a review from shamoon May 12, 2024 18:23
@shamoon shamoon enabled auto-merge (squash) May 12, 2024 19:26
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, think it just needs a re-base on dev

@shamoon shamoon added this to the Next Release milestone May 12, 2024
auto-merge was automatically disabled May 12, 2024 20:49

Head branch was pushed to by a user without write access

@shamoon shamoon merged commit 52350f8 into paperless-ngx:dev May 12, 2024
20 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request May 14, 2024
…gx to v2.8.4@25909b5 by renovate (#22005)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/paperless-ngx/paperless-ngx](https://togithub.com/paperless-ngx/paperless-ngx)
| patch | `2.8.3` -> `2.8.4` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>paperless-ngx/paperless-ngx
(ghcr.io/paperless-ngx/paperless-ngx)</summary>

###
[`v2.8.4`](https://togithub.com/paperless-ngx/paperless-ngx/releases/tag/v2.8.4):
Paperless-ngx v2.8.4

[Compare
Source](https://togithub.com/paperless-ngx/paperless-ngx/compare/v2.8.3...v2.8.4)

#### paperless-ngx 2.8.4

##### Features

- Enhancement: display current ASN in statistics
[@&#8203;darmiel](https://togithub.com/darmiel)
([paperless-ngx/paperless-ngx#6692)
- Enhancement: global search tweaks
[@&#8203;shamoon](https://togithub.com/shamoon)
([#&#8203;6674](https://togithub.com/paperless-ngx/paperless-ngx/pull/6674))

##### Bug Fixes

- Security: Correctly disable `eval` in pdfjs
[@&#8203;shamoon](https://togithub.com/shamoon)
([#&#8203;6702](https://togithub.com/paperless-ngx/paperless-ngx/pull/6702))
- Fix: history timestamp tooltip illegible in dark mode
[@&#8203;shamoon](https://togithub.com/shamoon)
([#&#8203;6696](https://togithub.com/paperless-ngx/paperless-ngx/pull/6696))
- Fix: only count inbox documents from inbox tags with permissions
[@&#8203;shamoon](https://togithub.com/shamoon)
([#&#8203;6670](https://togithub.com/paperless-ngx/paperless-ngx/pull/6670))

##### All App Changes

<details>
<summary>5 changes</summary>

- Enhancement: global search tweaks
[@&#8203;shamoon](https://togithub.com/shamoon)
([#&#8203;6674](https://togithub.com/paperless-ngx/paperless-ngx/pull/6674))
- Security: Correctly disable `eval` in pdfjs
[@&#8203;shamoon](https://togithub.com/shamoon)
([#&#8203;6702](https://togithub.com/paperless-ngx/paperless-ngx/pull/6702))
- Fix: history timestamp tooltip illegible in dark mode
[@&#8203;shamoon](https://togithub.com/shamoon)
([#&#8203;6696](https://togithub.com/paperless-ngx/paperless-ngx/pull/6696))
- Enhancement: display current ASN in statistics
[@&#8203;darmiel](https://togithub.com/darmiel)
([#&#8203;6692](https://togithub.com/paperless-ngx/paperless-ngx/pull/6692))
- Fix: only count inbox documents from inbox tags with permissions
[@&#8203;shamoon](https://togithub.com/shamoon)
([#&#8203;6670](https://togithub.com/paperless-ngx/paperless-ngx/pull/6670))

</details>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTguMCIsInVwZGF0ZWRJblZlciI6IjM3LjM1OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants