Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HMR with elm-hot #2378

Closed
wants to merge 729 commits into from
Closed

Add support for HMR with elm-hot #2378

wants to merge 729 commits into from

Conversation

ktosiek
Copy link
Contributor

@ktosiek ktosiek commented Dec 8, 2018 •
edited

↪️ Pull Request

This PR adds integration with elm-hot - the HMR solution for Elm (at least I don't know about any other :-)). I've published this code before as a plugin, and after a suggestion from @domenkozar decided it would make more sense upstream.

💻 Examples

This will help when editing the app without changing the type of the app's model. Visual tweaks or testing the update logic should be much easier with working HMR.

🚨 Test instructions

Editing an Elm app (like changing a string) should cause the changes to be applied, without refreshing the page or changing the app's state.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

devongovett and others added 30 commits April 15, 2018 19:58
@devongovett
1.7.1
8e99104
@devongovett
Update changelog
7d375a3
@devongovett
Change appveyor badge to master branch (parcel-bundler#1197)
18d795f
@devongovett
[Fix] Prevent build from breaking when .scss file is empty (parcel-bu…
512d680 
…ndler#1193)
@devongovett
Handle empty config files (parcel-bundler#1203)
27f3c85 
* handle empty config && asset files

* remove bad empty asset solution
@devongovett
Update dependency with security vuln (parcel-bundler#1246)
ee30bd7
@devongovett
Minor change to mkHandle in workerfarm (parcel-bundler#1233)
f4d1e66
@devongovett
Update default engines to > 0.25% (parcel-bundler#1238)
a688a9d 
Don’t use “last 2 versions”. See https://jamie.build/last-2-versions
@devongovett
use resolver for imports (parcel-bundler#1256)
83a1bfc
@devongovett
Don't start server if target isn't browser (parcel-bundler#1204)
42be29b
@devongovett
return early instead of throwing (parcel-bundler#1260)
c12bc1e
@ameerthehacker @devongovett
Clear the console in browser on each HMR (parcel-bundler#1073)
8cfe0e2
@devongovett
change default behaviour to keep default values of form elements (par…
f75cc44 
…cel-bundler#1249)
@devongovett
Fix autoinstall infinite loop (parcel-bundler#1241)
79e8784
@devongovett
Allow spaces in filenames (parcel-bundler#1212)
08a0fb5
@eXon @devongovett
Expose modules as UMD (parcel-bundler#453)
d9502dd
@devongovett
Support source field in package.json to enable babel on symlinked mod…
9ecbf06 
…ules (parcel-bundler#1101)
@devongovett
Add support for multiple entry points (parcel-bundler#1119)
3120969
@devongovett
Update deps (parcel-bundler#1271)
96c1c37
@PeachScript @devongovett
Fix reference pass error in package config (parcel-bundler#1149)
3cb989e
@CvX @devongovett
Remove eval usage. Fixes CSP cases. (parcel-bundler#1133)
86a26da
@devongovett
Restore symlinks on windows (parcel-bundler#1274)
12f48d7
@devongovett
Don’t clear console in the tests
8556b47
@devongovett
Remove jsnext:main
2a2e91e 
The field is deprecated and replaced with package.module. Additionally it caused many issues with packages that used it incorrectly. Fixes parcel-bundler#844, parcel-bundler#1037, parcel-bundler#1048, parcel-bundler#1062.
@devongovett
Watch directories instead of individual files (parcel-bundler#1279)
b160783 
This prevents EMFILE errors on large projects caused by running out of file descriptors.
@fathyb @devongovett
Ignore dependencies in falsy branches (parcel-bundler#1166)
c171f24
@devongovett
Only close the watcher after the ready event is emitted
4d65be1
@lqdchrm @devongovett
fix for outFile option; respect file-extension (parcel-bundler#1228) (p…
5e57b81 
…arcel-bundler#1229)
@devongovett
Only close watcher, don’t ignore path
12e165f
@devongovett
Ignore .cache and .git folders from watcher
448dcf3
padmaia and others added 16 commits October 19, 2018 15:28
@padmaia @devongovett
Extract watcher into its own package (parcel-bundler#2176)
cbeadd7
@timneutkens @devongovett
Make dynamic import name relative to the file importing it (parcel-bu…
3d6a621 
…ndler#2174)
@devongovett
Prettier
05437f8
@devongovett
Add --host option (parcel-bundler#2181)
2c14995 
Closes parcel-bundler#1482.
@DeMoorJasper @devongovett
Merge fs-watcher-child into Parcel's monorepo (parcel-bundler#2197)
060db2e
@thisconnect @DeMoorJasper
update postcss and deps (parcel-bundler#2203)
494e52d 
* update postcss and deps

* lock down bsb-js to 1.0.2 to fix node v6

* Update package.json
@gustavogodoi @devongovett
Update contributors broken link in CONTRIBUTING.md (parcel-bundler#2232)
cbbbbbe
@devongovett
catch css file not found (parcel-bundler#2206)
9136cdc
@AndreasPizsa @devongovett
fix: Treat webmanifest as an entry module (parcel-bundler#2254)
d8ddcaf
@Maxim-Filimonov @devongovett
add debugger flag for non production builds in Elm (parcel-bundler#2225)
3bc7062
@clarkdo @devongovett
refactor: JSON.stringify replacer can not be boolean (parcel-bundler#…
badc3ab 
…2276)
@phlmn @DeMoorJasper
fix: remove Date.toLocaleString() in logfile names to prevent slashes (…
4773d65 
…parcel-bundler#2288)
@mischnic @devongovett
Scope hoisting renaming after babel transforms (parcel-bundler#2292)
0937705
@ABuffSeagull @devongovett
Switch from toml to @iarna/toml (parcel-bundler#2298)
25b64d9 
As toml is an abandoned package, switch to @iarna/toml
for implementation of the latest toml spec (v0.5.0).
Also remove tomlify-j0.4, as @iarna/toml supports encoding
and decoding.
Resolves parcel-bundler#2258.
@vagisha-nidhi @devongovett
Test reports are not being published to Azure Pipelines (parcel-bundl…
52e3644 
…er#2302)
@DeMoorJasper @devongovett
update deasync to 0.1.14 (parcel-bundler#2337)
21d6cde
@domenkozar
Copy link

It also probably needs elm-hot dependency? :)

@ktosiek
Copy link
Contributor Author

ktosiek commented Dec 10, 2018

Doesn't localRequire take care of installing dependencies?

@domenkozar
Copy link

Ah, could be. I wonder why no tests ran via CI.

@DeMoorJasper
Copy link
Member

@ktosiek yes localRequire does that but probably a good idea to add it to devDeps to run tests a lil faster and reliable

Sent with GitHawk

@ktosiek
Copy link
Contributor Author

ktosiek commented Dec 10, 2018

@DeMoorJasper thank you, I've added it.
@domenkozar I guess because I've created the PR against the 1.x branch.

I'm not sure what the status is on 1.x vs 2.x, if the 1.x branch isn't developed anymore I'd be happy to rebase onto 2.x.

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Dec 10, 2018 •
edited

@ktosiek v1.x is still being actively developed and maintained.

However the core team is currently mainly focusing on v2.x afaik.
It's still pretty far from being released as the latest stable version of parcel, so contributions to parcel 1 are still very welcome :)

Not sure why CI didn't run though

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Dec 10, 2018 •
edited

@ktosiek I just saw why the tests aren't running, the v1.x branch is a backup of master before the monorepo. The master branch is the new v1.x branch

Could you rebase this on the master branch?

@ktosiek ktosiek closed this Dec 10, 2018
@ktosiek
Copy link
Contributor Author

ktosiek commented Dec 10, 2018

Sure! I've assumed master is 2.x, because of the amount of changes :-)

@ktosiek ktosiek changed the base branch from 1.x to master December 10, 2018 22:10
@ktosiek ktosiek mentioned this pull request Dec 10, 2018
Merged
3 tasks
@ktosiek
Copy link
Contributor Author

ktosiek commented Dec 10, 2018

I'm not sure what happened here, I've opened #2388 in place of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet