Fix autoinstall of cssnano #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
commented
Dec 14, 2018
| @@ -54,11 +54,8 @@ async function getConfig(asset) { | |||
| } | |||
|
|
|||
| if (asset.options.minify) { | |||
| let [cssnano, {version}] = await Promise.all( | |||
| ['cssnano', 'cssnano/package.json'].map(name => | |||
| localRequire(name, asset.name).catch(() => require(name)) | |||
There was a problem hiding this comment.
.catch(() => require(name))
What was that for?
There was a problem hiding this comment.
not sure, seems unnecessary. do you remember @DeMoorJasper?
|
Or this should be fixed in |
|
This is a fine fix for now. I do think we should fix the parsing of package names in |
devongovett
approved these changes
Dec 17, 2018
3 tasks
-> #2425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes autoinstalling of cssnano (previously, parcel tried to install the package "cssnano/package.json".
Fixes #2290, this seems to be a cleaner/easier fix than what was proposed there.
With this change,
localrequire("cssnano/package.json")never fails, because it will only run after cssnano is installed.Should there be a test for this? If yes, how should that look like?
💻 Examples
🚨 Test instructions
Building any html file which imports a css file.
✔️ PR Todo